Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#14999: Update scatter golden function #14998

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#14999: Update scatter golden function #14998

wants to merge 1 commit into from
+64 −2

Conversation

VirdhatchaniKN
Copy link
Contributor

@VirdhatchaniKN VirdhatchaniKN commented Nov 13, 2024 •
edited
Loading

Work done :

  • Update scatter golden function
  • Test file for scatter

https://github.com/tenstorrent/tt-metal/actions/runs/11818361407

@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/scatter_update branch 2 times, most recently from 6f449c4 to 8e2e994 Compare November 13, 2024 12:16
@VirdhatchaniKN VirdhatchaniKN changed the title #0: Update scatter #14999: Update scatter golden function Nov 13, 2024
Aswinmcw
Aswinmcw approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Aswinmcw Aswinmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ajakovljevicTT
ajakovljevicTT approved these changes Nov 13, 2024
View reviewed changes
Copy link

@ajakovljevicTT ajakovljevicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to all for the quick response! LGTM

@VirdhatchaniKN VirdhatchaniKN linked an issue Nov 13, 2024 that may be closed by this pull request
Scatter op - Update Golden function #14999
Open
@VirdhatchaniKN VirdhatchaniKN mentioned this pull request Nov 13, 2024
Open
@VirdhatchaniKN VirdhatchaniKN marked this pull request as ready for review November 13, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajakovljevicTT ajakovljevicTT ajakovljevicTT approved these changes

@ayerofieiev-tt ayerofieiev-tt ayerofieiev-tt approved these changes

@Aswinmcw Aswinmcw Aswinmcw approved these changes

@eyonland eyonland eyonland approved these changes

@umadevimcw umadevimcw umadevimcw approved these changes

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scatter op - Update Golden function
6 participants
@VirdhatchaniKN @umadevimcw @eyonland @Aswinmcw @ayerofieiev-tt @ajakovljevicTT