Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13929: Update the input range for ldexp test #14996

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#13929: Update the input range for ldexp test #14996

wants to merge 2 commits into from
+9 −12

Conversation

umadevimcw
Copy link
Contributor

@umadevimcw umadevimcw commented Nov 13, 2024 •
edited
Loading

Ticket

#13929

Problem description

PCC for ldexp is 0.98

What's changed

  • Ldexp op depend on exp because of the when we go for larger range of input the pcc is dropped hence updated the ranges for the test
  • Explanation
  • Updated the doc
image

Checklist

@umadevimcw umadevimcw force-pushed the umadevimcw/ldexp_bw_issue branch 2 times, most recently from 9d97179 to 0b2ff25 Compare November 14, 2024 09:03
@umadevimcw umadevimcw mentioned this pull request Nov 14, 2024
Open
@umadevimcw umadevimcw marked this pull request as ready for review November 14, 2024 13:34
Aswinmcw
Aswinmcw approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@Aswinmcw Aswinmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umadevimcw umadevimcw force-pushed the umadevimcw/ldexp_bw_issue branch 3 times, most recently from aa68277 to b96d41b Compare November 14, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcw-anasuya mcw-anasuya mcw-anasuya approved these changes

@Aswinmcw Aswinmcw Aswinmcw approved these changes

@VirdhatchaniKN VirdhatchaniKN VirdhatchaniKN approved these changes

@eyonland eyonland eyonland approved these changes

@patrickroberts patrickroberts Awaiting requested review from patrickroberts patrickroberts is a code owner

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy yan-zaretskiy is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin xanderchin is a code owner

@jdesousa-TT jdesousa-TT Awaiting requested review from jdesousa-TT jdesousa-TT is a code owner

@sjameelTT sjameelTT Awaiting requested review from sjameelTT sjameelTT is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@umadevimcw @eyonland @VirdhatchaniKN @Aswinmcw @mcw-anasuya