Add support for multi-device tensors in grouped convolution weight preprocessing #14914
+179
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esmalTT
force-pushed
the
esmal/multi-device-grouped-weight
branch
2 times, most recently
from
ce16c4f
to
f93e866
Compare
esmalTT
requested review from
cfjchu,
ayerofieiev-tt and
dmakoviichuk-tt
as code owners
esmalTT
force-pushed
the
esmal/multi-device-grouped-weight
branch
from
f93e866
to
1d5473e
Compare
|
Added |
4 tasks
cfjchu
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently - convolution weight preprocessing for grouped convolutions fails when using multi-device tensors. This PR adds support for using multi-device tensors with grouped convolutions.
I added
ttnn.conv2dtests that cover multi-device convolutions forgroups >= 1and also fixed formatting intensor_utils.cpp.Checklist