Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14690: Reorganize gtests under tests/tt_metal/tt_metal #14691

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

sagarwalTT
Copy link
Contributor

Ticket

#14690

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/5)

@@ -1,7 +1,7 @@
// SPDX-FileCopyrightText: © 2023 Tenstorrent Inc.
//
// SPDX-License-Identifier: Apache-2.0
#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found


#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -6,7 +6,7 @@
#include <functional>
#include <random>

#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/5)

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -4,13 +4,13 @@

// This file contains dispatch tests that are (generally) dispatch mode agnostic

#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

@@ -6,7 +6,7 @@
#include <functional>
#include <random>

#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

@@ -3,10 +3,11 @@
// SPDX-License-Identifier: Apache-2.0

#include "bit_utils.h"
#include "host_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
host_fixture.hpp file not found

@@ -4,10 +4,6 @@

#include <gtest/gtest.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
gtest/gtest.h file not found

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (3/5)

tests/tt_metal/tt_metal/common/buffer_fixtures.hpp Outdated Show resolved Hide resolved

#pragma once

#include <gtest/gtest.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
gtest/gtest.h file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -4,8 +4,8 @@

#include <cstddef>
#include <cstdint>
#include <memory>
#include "command_queue_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
command_queue_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

@@ -3,7 +3,7 @@
// SPDX-License-Identifier: Apache-2.0

#include "common/bfloat16.hpp"
#include "dprint_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -1,7 +1,7 @@
// SPDX-FileCopyrightText: © 2023 Tenstorrent Inc.
//
// SPDX-License-Identifier: Apache-2.0
#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (4/5)

@@ -1,7 +1,7 @@
// SPDX-FileCopyrightText: © 2023 Tenstorrent Inc.
//
// SPDX-License-Identifier: Apache-2.0
#include "dprint_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -6,7 +6,7 @@
#include <functional>
#include <random>

#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -1,7 +1,7 @@
// SPDX-FileCopyrightText: © 2023 Tenstorrent Inc.
//
// SPDX-License-Identifier: Apache-2.0
#include "dprint_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -4,7 +4,7 @@

#include <gtest/gtest.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
gtest/gtest.h file not found

tests/tt_metal/tt_metal/common/trace_fixtures.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (5/5)

@@ -3,7 +3,7 @@
// SPDX-License-Identifier: Apache-2.0

#include "llrt/rtoptions.hpp"
#include "watcher_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found


// A version of CommonFixture with watcher enabled
class WatcherFixture: public CommonFixture {
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixtures.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixtures.hpp file not found

tests/tt_metal/tt_metal/common/event_fixture.hpp Outdated Show resolved Hide resolved
@@ -6,7 +6,7 @@
#include <functional>
#include <random>

#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

@@ -3,6 +3,7 @@
// SPDX-License-Identifier: Apache-2.0

#include "command_queue_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
command_queue_fixture.hpp file not found

@@ -6,7 +6,7 @@
#include <functional>
#include <random>

#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

@@ -6,7 +6,7 @@
#include <functional>
#include <random>

#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

Copy link
Contributor

@abhullar-tt abhullar-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

From going through this a couple categories that could help define the structure stick out to me:

  • a bring-up / basic section in the unit_test dir and unit_test_common. These tests would go through minimal Metal RT codepath but what we need working before we try running more complex codepaths
  • LLK section, LLK team has been adding parameterized single core slow dispatch tests under "compute"
  • API constructs section: tests that create/initialize rt args, semaphores, circular buffers, kernels, programs, allocator (these wouldn't necessarily run anything on device but serve as the base complexity level of RT / flush out API rules)
  • Fast dispatch tests: single chip/multi-chip enqueue APIs
  • Launching programs: these can be incrementally complex as Paul mentioned (test loading a kernel, tests that test across eth/tensix, complex use cases)

tests/tt_metal/tt_metal/common/program_fixtures.hpp Outdated Show resolved Hide resolved
@@ -81,7 +81,7 @@ bool dram_ping(
}
} // namespace unit_tests::basic::device

TEST_F(BasicFixture, SingleDeviceHarvestingPrints) {
TEST_F(BasicFixture, TensixSingleDeviceHarvestingPrints) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should be prepended with test -> test_device.cpp. Also, I think we should rename BasicFixture -> BasicDeviceFixture. Most of the tests that are in this file should use that fixture because they are the basic functionalities that we expect when bringing up/running on device.

Maybe "basic" -> "bringup" and then we can have a bring-up device folder (these could be the least complex tests with minimal RT features but basic host <-> device interactions that are in more complex codepaths

@@ -102,7 +102,7 @@ void try_creating_more_than_max_num_semaphores(

} // namespace unit_tests::initialize_semaphores

TEST_F(DeviceFixture, InitializeLegalSemaphores) {
TEST_F(DeviceFixture, TensixInitializeLegalSemaphores) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: prefix test file with test_*

I know the structure isn't finalized but I don't think this belongs in basic/bringup folder. We should have a separate dir where we test API constructs

@@ -168,7 +168,7 @@ bool verify_results(
}

// Write unique and common runtime args to device and readback to verify written correctly.
TEST_F(DeviceFixture, LegallyModifyRTArgsDataMovement) {
TEST_F(DeviceFixture, TensixLegallyModifyRTArgsDataMovement) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be moved to api constructs

@@ -72,7 +72,7 @@ void read_translation_table (Device* device, CoreCoord logical_node, std::vector



TEST_F(BasicFixture, VerifyNocNodeIDs) {
TEST_F(BasicFixture, TensixVerifyNocNodeIDs) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this definitely belongs in basic or bringup

@@ -289,11 +289,11 @@ void run_single_core_broadcast(tt_metal::Device* device, const BroadcastConfig&
}
}

class BroadcastParametrizedDeviceFixture : public DeviceFixture,
class BroadcastParameterizedDeviceFixture : public DeviceFixture,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently everything in unit_tests/compute are meant to be simple single core LLK test. I think we should have a dedicated LLK or Compute fixture for all the tests in this directory that currently run using DeviceFixture

@@ -372,7 +372,7 @@ bool reader_datacopy_writer(tt_metal::Device* device, const ReaderDatacopyWriter
}
} // namespace unit_tests::dram::direct

TEST_F(DeviceFixture, SingleCoreDirectDramReaderOnly) {
TEST_F(DeviceFixture, TensixSingleCoreDirectDramReaderOnly) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be moved to the bring-up folder

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp"
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be moved to api constructs dir

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/2)

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -3,7 +3,7 @@
// SPDX-License-Identifier: Apache-2.0

#include "common/bfloat16.hpp"
#include "dprint_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found


// A version of CommonFixture with watcher enabled
class WatcherFixture: public CommonFixture {
#include "dispatch_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
dispatch_fixture.hpp file not found

@@ -1,7 +1,7 @@
// SPDX-FileCopyrightText: © 2023 Tenstorrent Inc.
//
// SPDX-License-Identifier: Apache-2.0
#include "dprint_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/2)


#pragma once

#include <gtest/gtest.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
gtest/gtest.h file not found

@@ -1,7 +1,7 @@
// SPDX-FileCopyrightText: © 2023 Tenstorrent Inc.
//
// SPDX-License-Identifier: Apache-2.0
#include "dprint_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "watcher_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@@ -3,7 +3,7 @@
// SPDX-License-Identifier: Apache-2.0

#include "llrt/rtoptions.hpp"
#include "watcher_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found


#pragma once

#include "gtest/gtest.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
gtest/gtest.h file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found


#pragma once

#include <gtest/gtest.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
gtest/gtest.h file not found

@@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: Apache-2.0

#include "dprint_fixture.hpp"
#include "debug_tools_fixture.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-diagnostic-error ⚠️
debug_tools_fixture.hpp file not found

@sagarwalTT sagarwalTT force-pushed the sagarwal/fix-test-naming branch 10 times, most recently from f1e99a8 to b7996aa Compare November 12, 2024 14:55
@sagarwalTT sagarwalTT force-pushed the sagarwal/fix-test-naming branch 3 times, most recently from 384da63 to 953bd0b Compare November 14, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants