Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply obvious fixes for issues identified during initial sweep run #13456

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SeanNijjar
Copy link
Contributor

@SeanNijjar SeanNijjar commented Oct 3, 2024

Ticket

Link to Github Issue

Problem description

During an initial run through of the n300 allgather sweep tests, a handful of "obvious" errors were identified. This PR resolves those obvious issues

What's changed

A few changes:

  • Relaxed test case invalidation at pytest level that would be overly conservative and skip some cases because it thought they couldn't fit in L1/DRAM (even though they could)
  • Updated timeout for sweeps as it was too long (after reset, device initialization seemed to take a while, often time leading to another timeout before the main test body was even enterred
  • Fixed all-gather edm buffer sizing to support (much) larger pages.

Checklist

@SeanNijjar SeanNijjar changed the title Snijjar/sweeps Apply obvious fixes for issues identified during initial sweep run Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants