Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: fix CCL nightly and frequent test reqression suites #13349

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

cfjchu
Copy link
Collaborator

@cfjchu cfjchu commented Oct 1, 2024

Ticket

Link to Github Issue

Problem description

fix CCL nightly and frequent test reqression suites

What's changed

  • fixture requires annotating PCIE device IDs to reset the devices when timeout happens
  • change pcie_mesh_device fixture to rely on offset instead of physical_device_ids because the device id enumeration can cause physical_device_ids to not necessarily be ordered in a ring.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@cfjchu cfjchu merged commit 9aa4c23 into main Oct 1, 2024
130 of 133 checks passed
@cfjchu cfjchu deleted the jchu/fix-ccl-nightly-frequent branch October 1, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants