Skip to content

Commit

Permalink
#13548: Remove default argument values for DstSync parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
@amahmudTT
Anil Mahmud authored and amahmudTT committed Oct 13, 2024
1 parent bb862e3 commit b1f3b08
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions tt_metal/hw/ckernels/blackhole/metal/llk_api/llk_math_unary_datacopy_api.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ template <
bool unpack_to_dest = false>
inline void llk_math_eltwise_unary_datacopy(uint dst_index, uint operand = 0) {
const std::uint32_t operand_id = get_operand_id(operand);
_llk_math_eltwise_unary_datacopy_<type, src_b_bcast_type, DST_SYNC_MODE, is_fp32_dest_acc_en, unpack_to_dest>(
_llk_math_eltwise_unary_datacopy_<type, DST_SYNC_MODE, src_b_bcast_type, is_fp32_dest_acc_en, unpack_to_dest>(
dst_index, unpack_src_format[operand_id], unpack_dst_format[operand_id]);
}

Expand All @@ -33,8 +33,8 @@ inline void llk_math_eltwise_unary_datacopy_block(uint start_dst_index, uint nti
for (uint32_t dst_index = start_dst_index; dst_index < start_dst_index + ntiles; dst_index++) {
_llk_math_eltwise_unary_datacopy_<
type,
src_b_bcast_type,
DST_SYNC_MODE,
src_b_bcast_type,
is_fp32_dest_acc_en,
unpack_to_dest>(dst_index, unpack_src_format[operand_id], unpack_dst_format[operand_id]);
}
Expand Down
2 changes: 1 addition & 1 deletion tt_metal/hw/ckernels/grayskull/metal/llk_api/llk_math_unary_datacopy_api.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ template <
bool unpack_to_dest = false>
inline void llk_math_eltwise_unary_datacopy(uint dst_index, uint operand = 0 /* unused */) {

_llk_math_eltwise_unary_datacopy_<type, src_b_bcast_type, DST_SYNC_MODE, is_fp32_dest_acc_en>(dst_index);
_llk_math_eltwise_unary_datacopy_<type, DST_SYNC_MODE, src_b_bcast_type, is_fp32_dest_acc_en>(dst_index);
}

template <DataCopyType type, BroadcastType src_b_bcast_type = BroadcastType::NONE, bool is_fp32_dest_acc_en = false, bool unpack_to_dest = false>
Expand Down
4 changes: 2 additions & 2 deletions tt_metal/hw/ckernels/grayskull/metal/llk_api/llk_pack_api.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ inline void llk_pack(std::uint32_t tile_index, std::uint32_t output, std::uint32

std::uint32_t pack_tile_addr = get_output_tile_address<out_of_order_output, untilize>(output_id, output_tile_index);

_llk_pack_<out_of_order_output, DST_SYNC_MODE, untilize, is_fp32_dest_acc_en>(
_llk_pack_<DST_SYNC_MODE, out_of_order_output, untilize, is_fp32_dest_acc_en>(
tile_index,
pack_dst_format[output_id],
pack_tile_addr
Expand Down Expand Up @@ -282,7 +282,7 @@ inline void llk_matmul_pack(const std::uint32_t start_tile_index, const std::uin

std::uint32_t pack_tile_addr = get_output_tile_address<out_of_order_output, untilize>(output_id, output_tile_index);

_llk_pack_<out_of_order_output, DST_SYNC_MODE, untilize, is_fp32_dest_acc_en>(
_llk_pack_<DST_SYNC_MODE, out_of_order_output, untilize, is_fp32_dest_acc_en>(
tile_index,
pack_dst_format[output_id],
pack_tile_addr
Expand Down
4 changes: 2 additions & 2 deletions tt_metal/hw/ckernels/wormhole_b0/metal/llk_api/llk_math_unary_datacopy_api.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ template <
bool unpack_to_dest = false>
inline void llk_math_eltwise_unary_datacopy(uint dst_index, uint operand = 0) {
const std::uint32_t operand_id = get_operand_id(operand);
_llk_math_eltwise_unary_datacopy_<type, src_b_bcast_type, DST_SYNC_MODE, is_fp32_dest_acc_en, unpack_to_dest>(
_llk_math_eltwise_unary_datacopy_<type, DST_SYNC_MODE, src_b_bcast_type, is_fp32_dest_acc_en, unpack_to_dest>(
dst_index, unpack_src_format[operand_id], unpack_dst_format[operand_id]);
}

Expand All @@ -31,7 +31,7 @@ inline void llk_math_eltwise_unary_datacopy_block(uint start_dst_index, uint nti
const std::uint32_t operand_id = get_operand_id(operand);

for (uint32_t dst_index = start_dst_index; dst_index < start_dst_index + ntiles; dst_index++) {
_llk_math_eltwise_unary_datacopy_<type, src_b_bcast_type, DST_SYNC_MODE, is_fp32_dest_acc_en, unpack_to_dest>(
_llk_math_eltwise_unary_datacopy_<type, DST_SYNC_MODE, src_b_bcast_type, is_fp32_dest_acc_en, unpack_to_dest>(
dst_index, unpack_src_format[operand_id], unpack_dst_format[operand_id]);
}
}
Expand Down
2 changes: 1 addition & 1 deletion tt_metal/third_party/tt_llk_blackhole
Submodule tt_llk_blackhole updated 8 files
+3,571 −0 instructions/assembly.yaml
+1 −1 llk_lib/llk_math_common.h
+1 −1 llk_lib/llk_math_eltwise_binary.h
+1 −1 llk_lib/llk_math_eltwise_binary_sfpu.h
+1 −1 llk_lib/llk_math_eltwise_unary_datacopy.h
+20 −20 llk_lib/llk_math_eltwise_unary_sfpi.h
+1 −1 llk_lib/llk_math_eltwise_unary_sfpu.h
+1 −1 llk_lib/llk_pack.h
2 changes: 1 addition & 1 deletion tt_metal/third_party/tt_llk_grayskull
Submodule tt_llk_grayskull updated 7 files
+1,956 −0 instructions/assembly.yaml
+1 −1 llk_lib/llk_math_common.h
+1 −1 llk_lib/llk_math_eltwise_binary.h
+1 −1 llk_lib/llk_math_eltwise_unary_datacopy.h
+15 −15 llk_lib/llk_math_eltwise_unary_sfpi.h
+1 −1 llk_lib/llk_math_eltwise_unary_sfpu.h
+1 −1 llk_lib/llk_pack.h
2 changes: 1 addition & 1 deletion tt_metal/third_party/tt_llk_wormhole_b0
Submodule tt_llk_wormhole_b0 updated 8 files
+3,008 −0 instructions/assembly.yaml
+1 −1 llk_lib/llk_math_common.h
+1 −1 llk_lib/llk_math_eltwise_binary.h
+1 −1 llk_lib/llk_math_eltwise_binary_sfpu.h
+1 −1 llk_lib/llk_math_eltwise_unary_datacopy.h
+20 −20 llk_lib/llk_math_eltwise_unary_sfpi.h
+1 −1 llk_lib/llk_math_eltwise_unary_sfpu.h
+1 −1 llk_lib/llk_pack.h

0 comments on commit b1f3b08

Please sign in to comment.