Skip to content

Commit

Permalink
#14267: Use snake_case
Browse files Browse the repository at this point in the history
  • Loading branch information
Aswinmcw committed Oct 29, 2024
1 parent a9da50f commit 8e480d7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ AllGather create_all_gather_struct(
) {
uint32_t num_devices = devices.size();
auto [device_index, sender_device_id, receiver_device_id] =
getDeviceIndexAndSenderReceiverIDs(input_tensor, devices, topology);
get_device_index_and_sender_receiver_ids(input_tensor, devices, topology);

return ttnn::AllGather{
dim, num_links, num_devices, device_index, user_defined_num_workers, user_defined_num_buffers_per_channel, receiver_device_id, sender_device_id, memory_config.value_or(input_tensor.memory_config()), topology};
Expand Down
2 changes: 1 addition & 1 deletion ttnn/cpp/ttnn/operations/ccl/ccl_common.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
namespace ttnn {
namespace ccl {

std::tuple<uint32_t, std::optional<chip_id_t>, std::optional<chip_id_t>> getDeviceIndexAndSenderReceiverIDs(
std::tuple<uint32_t, std::optional<chip_id_t>, std::optional<chip_id_t>> get_device_index_and_sender_receiver_ids(
const Tensor& input_tensor,
const std::vector<Device*>& devices,
const ttnn::ccl::Topology& topology) {
Expand Down
2 changes: 1 addition & 1 deletion ttnn/cpp/ttnn/operations/ccl/ccl_common.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
namespace ttnn {
namespace ccl {

std::tuple<uint32_t, std::optional<chip_id_t>, std::optional<chip_id_t>> getDeviceIndexAndSenderReceiverIDs(
std::tuple<uint32_t, std::optional<chip_id_t>, std::optional<chip_id_t>> get_device_index_and_sender_receiver_ids(
const Tensor& input_tensor,
const std::vector<Device*>& devices,
const ttnn::ccl::Topology& topology);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ Tensor reduce_scatter(

const auto& input_tensor = input_tensors.at(0);
auto [device_index, sender_device_id, receiver_device_id] =
getDeviceIndexAndSenderReceiverIDs(input_tensor, devices, topology);
get_device_index_and_sender_receiver_ids(input_tensor, devices, topology);

TT_FATAL(receiver_device_id != std::nullopt || sender_device_id != std::nullopt, "Error, Reduce-scatter was unable to identify either a sender or receiver device ID and atleast one must be identified for a valid Reduce-scatter configuration. The input mesh tensor or Reduce-scatter arguments may be incorrect");

Expand Down

0 comments on commit 8e480d7

Please sign in to comment.