Skip to content

Commit

Permalink
#3939: rename KernelID -> KernelHandle and CircularBufferID -> CBHandle
Browse files Browse the repository at this point in the history
  • Loading branch information
@TT-billteng
TT-billteng committed Nov 26, 2023
1 parent 26ecc73 commit 882fe5f
Show file tree
Hide file tree
Showing 90 changed files with 330 additions and 330 deletions.
4 changes: 2 additions & 2 deletions docs/source/tt_metal/apis/host_apis/runtime_args/runtime_args.rst
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Runtime Arguments
==================

.. doxygenfunction:: SetRuntimeArgs(const Program &program, KernelID kernel_id, const std::variant<CoreCoord,CoreRange,CoreRangeSet> &logical_core, const std::vector<uint32_t> &runtime_args)
.. doxygenfunction:: SetRuntimeArgs(const Program &program, KernelHandle kernel_id, const std::variant<CoreCoord,CoreRange,CoreRangeSet> &logical_core, const std::vector<uint32_t> &runtime_args)

.. doxygenfunction:: SetRuntimeArgs(const Program &program, KernelID kernel, const std::vector< CoreCoord > & core_spec, const std::vector< std::vector<uint32_t> > &runtime_args)
.. doxygenfunction:: SetRuntimeArgs(const Program &program, KernelHandle kernel, const std::vector< CoreCoord > & core_spec, const std::vector< std::vector<uint32_t> > &runtime_args)

.. doxygenfunction:: GetRuntimeArgs
2 changes: 1 addition & 1 deletion docs/source/tt_metal/examples/dram_loopback.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ We will be using the accelerator core with coordinates ``{0, 0}``.
constexpr CoreCoord core = {0, 0};
KernelID dram_copy_kernel_id = CreateKernel(
KernelHandle dram_copy_kernel_id = CreateKernel(
program,
"tt_metal/programming_examples/loopback/kernels/loopback_dram_copy.cpp",
core,
Expand Down
8 changes: 4 additions & 4 deletions docs/source/tt_metal/examples/eltwise_binary.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,19 @@ We already have set the circular buffers needed for compute data communication.
constexpr uint32_t num_input_tiles = 2;
constexpr uint32_t input_cb_size = num_input_tiles * single_tile_size;
CircularBufferConfig cb_src0_config = CircularBufferConfig(input_cb_size, {{src0_cb_index, tt::DataFormat::Float16_b}}, src0_cb_addr).set_page_size(src0_cb_index, single_tile_size);
CircularBufferID cb_src0 = CreateCircularBuffer(program, core, cb_src0_config);
CBHandle cb_src0 = CreateCircularBuffer(program, core, cb_src0_config);
constexpr uint32_t src1_cb_index = CB::c_in1;
constexpr uint32_t src1_cb_addr = 300 * 1024;
CircularBufferConfig cb_src1_config = CircularBufferConfig(input_cb_size, {{src1_cb_index, tt::DataFormat::Float16_b}}, src1_cb_addr).set_page_size(src1_cb_index, single_tile_size);
CircularBufferID cb_src1 = CreateCircularBuffer(program, core, cb_src1_config);
CBHandle cb_src1 = CreateCircularBuffer(program, core, cb_src1_config);
constexpr uint32_t output_cb_index = CB::c_out0;
constexpr uint32_t output_cb_addr = 400 * 1024;
constexpr uint32_t num_output_tiles = 2;
constexpr uint32_t input_cb_size = num_input_tiles * single_tile_size;
CircularBufferConfig cb_output_config = CircularBufferConfig(input_cb_size, {{output_cb_index, tt::DataFormat::Float16_b}}, output_cb_addr).set_page_size(output_cb_index, single_tile_size);
CircularBufferID cb_output = CreateCircularBuffer(program, core, cb_output);
CBHandle cb_output = CreateCircularBuffer(program, core, cb_output);
We will create two input circular buffers to accommodate our two input tensors,
and an output one for the result of the eltwise binary operation.
Expand All @@ -48,7 +48,7 @@ Compute kernel declaration and compile-time defines

.. code-block:: cpp
KernelID eltwise_binary_kernel_id = CreateKernel(
KernelHandle eltwise_binary_kernel_id = CreateKernel(
program,
"tt_metal/kernels/compute/eltwise_binary.cpp",
core,
Expand Down
6 changes: 3 additions & 3 deletions docs/source/tt_metal/examples/eltwise_sfpu.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ compute, and writer engines.
constexpr uint32_t src0_cb_index = CB::c_in0;
constexpr uint32_t num_input_tiles = 2;
CircularBufferConfig cb_src0_config = CircularBufferConfig(num_input_tiles * single_tile_size, {{src0_cb_index, tt::DataFormat::Float16_b}}).set_page_size(src0_cb_index, single_tile_size);
CircularBufferID cb_src0 = tt_metal::CreateCircularBuffer(program, core, cb_src0_config);
CBHandle cb_src0 = tt_metal::CreateCircularBuffer(program, core, cb_src0_config);
constexpr uint32_t output_cb_index = CB::c_out0;
constexpr uint32_t num_output_tiles = 2;
CircularBufferConfig cb_output_config = CircularBufferConfig(num_output_tiles * single_tile_size, {{output_cb_index, tt::DataFormat::Float16_b}}).set_page_size(output_cb_index, single_tile_size);
CircularBufferID cb_output = tt_metal::CreateCircularBuffer(program, core, cb_output_config);
CBHandle cb_output = tt_metal::CreateCircularBuffer(program, core, cb_output_config);
We will create one input circular buffers to accommodate our input tensor,
and an output one for the result of the eltwise sfpu operation.
Expand Down Expand Up @@ -59,7 +59,7 @@ Compute kernel declaration and compile-time defines
{"SFPU_OP_CHAIN_0", "exp_tile_init(); exp_tile(0);"}
};
KernelID eltwise_sfpu_kernel_id = CreateKernel(
KernelHandle eltwise_sfpu_kernel_id = CreateKernel(
program,
"tt_metal/kernels/compute/eltwise_sfpu.cpp",
core,
Expand Down
8 changes: 4 additions & 4 deletions tests/tt_metal/tt_metal/perf_microbenchmark/matmul/matmul_global_l1.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,8 @@ tt_metal::Program create_program_mcast_in0_in1(
.noc = tt_metal::NOC::RISCV_0_default,
.compile_args = in0_receiver_compile_time_args});

KernelID mm_kernel_in1_receiver_writer_other_noc_setup_id = 0;
KernelID mm_kernel_in0_receiver_other_noc_setup_id = 0;
KernelHandle mm_kernel_in1_receiver_writer_other_noc_setup_id = 0;
KernelHandle mm_kernel_in0_receiver_other_noc_setup_id = 0;

if (split_half) {
mm_kernel_in1_receiver_writer_other_noc_setup_id =
Expand Down Expand Up @@ -586,8 +586,8 @@ tt_metal::Program create_program_mcast_in0_in1(
(per_core_M / out_subblock_h - last_block_num_nonzero_subblocks_h) *
(per_core_N * out_subblock_h);

std::vector<KernelID> reader_kernel_ids;
std::vector<KernelID> writer_kernel_ids;
std::vector<KernelHandle> reader_kernel_ids;
std::vector<KernelHandle> writer_kernel_ids;
for (int core_idx_y = 0; core_idx_y < num_cores_r; core_idx_y++) {
for (int core_idx_x = 0; core_idx_x < num_cores_c; core_idx_x++) {
CoreCoord core = {(std::size_t)start_core_x + core_idx_x,
Expand Down
2 changes: 1 addition & 1 deletion tests/tt_metal/tt_metal/test_add_two_ints.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ int main(int argc, char **argv) {
std::vector<uint32_t> first_runtime_args = {101, 202};
std::vector<uint32_t> second_runtime_args = {303, 606};

tt_metal::KernelID add_two_ints_kernel = tt_metal::CreateKernel(
tt_metal::KernelHandle add_two_ints_kernel = tt_metal::CreateKernel(
program, "tests/tt_metal/tt_metal/test_kernels/misc/add_two_ints.cpp", core,
tt_metal::DataMovementConfig{.processor = tt_metal::DataMovementProcessor::RISCV_0, .noc = tt_metal::NOC::RISCV_0_default});

Expand Down
4 changes: 2 additions & 2 deletions tests/tt_metal/tt_metal/test_compile_args.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ bool test_compile_args(std::vector<uint32_t> compile_args_vec, int device_id) {

CoreCoord core = {0, 0};

tt_metal::KernelID unary_reader_kernel = tt_metal::CreateKernel(
tt_metal::KernelHandle unary_reader_kernel = tt_metal::CreateKernel(
program,
"tests/tt_metal/tt_metal/test_kernels/dataflow/test_compile_args.cpp",
core,
tt_metal::DataMovementConfig{.processor = tt_metal::DataMovementProcessor::RISCV_1, .noc = tt_metal::NOC::RISCV_1_default, .compile_args = compile_args_vec});


tt_metal::KernelID unary_writer_kernel = tt_metal::CreateKernel(
tt_metal::KernelHandle unary_writer_kernel = tt_metal::CreateKernel(
program, "tt_metal/kernels/dataflow/blank.cpp",
core,
tt_metal::DataMovementConfig{.processor = tt_metal::DataMovementProcessor::RISCV_0, .noc = tt_metal::NOC::RISCV_0_default});
Expand Down
6 changes: 3 additions & 3 deletions tests/tt_metal/tt_metal/test_datacopy_multi_core_multi_dram.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ std::vector<bfloat16> select_columns(std::vector<bfloat16> data, int M, int K, i
return result;
}

std::tuple<tt_metal::Program, tt_metal::KernelID, tt_metal::KernelID> create_program(
std::tuple<tt_metal::Program, tt_metal::KernelHandle, tt_metal::KernelHandle> create_program(
tt_metal::Device *device,
int num_cores_r,
int num_cores_c,
Expand Down Expand Up @@ -171,8 +171,8 @@ bool write_runtime_args_to_device(
tt_metal::Program &program,
int num_cores_r,
int num_cores_c,
tt_metal::KernelID reader_kernel,
tt_metal::KernelID writer_kernel,
tt_metal::KernelHandle reader_kernel,
tt_metal::KernelHandle writer_kernel,
int tensor_num_tiles,
int block_num_tiles,
int Ht,
Expand Down
6 changes: 3 additions & 3 deletions tests/tt_metal/tt_metal/test_matmul_multi_core_multi_dram.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ std::vector<bfloat16> select_columns(std::vector<bfloat16> data, int M, int K, i
return result;
}

std::tuple<tt_metal::Program, tt_metal::KernelID, tt_metal::KernelID> create_program(
std::tuple<tt_metal::Program, tt_metal::KernelHandle, tt_metal::KernelHandle> create_program(
tt_metal::Device *device,
int num_cores_r,
int num_cores_c,
Expand Down Expand Up @@ -193,8 +193,8 @@ bool assign_runtime_args_to_program(
tt_metal::Program &program,
int num_cores_r,
int num_cores_c,
tt_metal::KernelID mm_reader_kernel,
tt_metal::KernelID unary_writer_kernel,
tt_metal::KernelHandle mm_reader_kernel,
tt_metal::KernelHandle unary_writer_kernel,
int M,
int N,
int K,
Expand Down
8 changes: 4 additions & 4 deletions tests/tt_metal/tt_metal/test_matmul_multi_core_multi_dram_in0_mcast.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ std::vector<bfloat16> select_columns(std::vector<bfloat16> data, int M, int K, i
return result;
}

std::tuple<tt_metal::Program, tt_metal::KernelID, tt_metal::KernelID, tt_metal::KernelID> create_program(
std::tuple<tt_metal::Program, tt_metal::KernelHandle, tt_metal::KernelHandle, tt_metal::KernelHandle> create_program(
tt_metal::Device *device,
int start_core_x,
int start_core_y,
Expand Down Expand Up @@ -216,9 +216,9 @@ bool write_runtime_args_to_device(
int start_core_y,
int num_cores_r,
int num_cores_c,
tt_metal::KernelID mm_reader_kernel_sender,
tt_metal::KernelID mm_reader_kernel_receiver,
tt_metal::KernelID unary_writer_kernel,
tt_metal::KernelHandle mm_reader_kernel_sender,
tt_metal::KernelHandle mm_reader_kernel_receiver,
tt_metal::KernelHandle unary_writer_kernel,
int M,
int N,
int K,
Expand Down
14 changes: 7 additions & 7 deletions tests/tt_metal/tt_metal/test_matmul_multi_core_multi_dram_in0_mcast_in1_mcast.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ std::vector<bfloat16> select_columns(std::vector<bfloat16> data, int M, int K, i
return result;
}

std::tuple<tt_metal::Program, tt_metal::KernelID, tt_metal::KernelID, tt_metal::KernelID, tt_metal::KernelID, tt_metal::KernelID, tt_metal::KernelID> create_program(
std::tuple<tt_metal::Program, tt_metal::KernelHandle, tt_metal::KernelHandle, tt_metal::KernelHandle, tt_metal::KernelHandle, tt_metal::KernelHandle, tt_metal::KernelHandle> create_program(
tt_metal::Device *device,
int start_core_x,
int start_core_y,
Expand Down Expand Up @@ -250,12 +250,12 @@ bool write_runtime_args_to_device(
int start_core_y,
int num_cores_r,
int num_cores_c,
tt_metal::KernelID mm_reader_kernel_in0_sender_in1_sender,
tt_metal::KernelID mm_reader_kernel_in0_sender_in1_receiver,
tt_metal::KernelID mm_reader_kernel_in0_receiver_in1_sender,
tt_metal::KernelID mm_reader_kernel_in0_receiver_in1_receiver,
tt_metal::KernelID unary_writer_kernel_noc0,
tt_metal::KernelID unary_writer_kernel_noc1,
tt_metal::KernelHandle mm_reader_kernel_in0_sender_in1_sender,
tt_metal::KernelHandle mm_reader_kernel_in0_sender_in1_receiver,
tt_metal::KernelHandle mm_reader_kernel_in0_receiver_in1_sender,
tt_metal::KernelHandle mm_reader_kernel_in0_receiver_in1_receiver,
tt_metal::KernelHandle unary_writer_kernel_noc0,
tt_metal::KernelHandle unary_writer_kernel_noc1,
int M,
int N,
int K,
Expand Down
8 changes: 4 additions & 4 deletions tests/tt_metal/tt_metal/test_matmul_multi_core_multi_dram_in1_mcast.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ std::vector<bfloat16> select_columns(std::vector<bfloat16> data, int M, int K, i
return result;
}

std::tuple<tt_metal::Program, tt_metal::KernelID, tt_metal::KernelID, tt_metal::KernelID> create_program(
std::tuple<tt_metal::Program, tt_metal::KernelHandle, tt_metal::KernelHandle, tt_metal::KernelHandle> create_program(
tt_metal::Device *device,
int start_core_x,
int start_core_y,
Expand Down Expand Up @@ -216,9 +216,9 @@ bool write_runtime_args_to_device(
int start_core_y,
int num_cores_r,
int num_cores_c,
tt_metal::KernelID mm_reader_kernel_sender,
tt_metal::KernelID mm_reader_kernel_receiver,
tt_metal::KernelID unary_writer_kernel,
tt_metal::KernelHandle mm_reader_kernel_sender,
tt_metal::KernelHandle mm_reader_kernel_receiver,
tt_metal::KernelHandle unary_writer_kernel,
int M,
int N,
int K,
Expand Down
2 changes: 1 addition & 1 deletion tests/tt_metal/tt_metal/test_matmul_multi_core_single_dram.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ std::vector<bfloat16> select_columns(std::vector<bfloat16> data, int M, int K, i
return result;
}

std::tuple<tt_metal::Program, tt_metal::KernelID , tt_metal::KernelID> create_program(tt_metal::Device *device, int num_cores_r, int num_cores_c, int per_core_M, int per_core_N, int K, int in0_block_w, int out_subblock_h, int out_subblock_w) {
std::tuple<tt_metal::Program, tt_metal::KernelHandle , tt_metal::KernelHandle> create_program(tt_metal::Device *device, int num_cores_r, int num_cores_c, int per_core_M, int per_core_N, int K, int in0_block_w, int out_subblock_h, int out_subblock_w) {
tt_metal::Program program = tt_metal::CreateProgram();
uint32_t single_tile_size = 2 * 1024;
uint32_t in0_block_tiles = per_core_M * in0_block_w;
Expand Down
12 changes: 6 additions & 6 deletions tests/tt_metal/tt_metal/test_multi_core_kernel.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
//////////////////////////////////////////////////////////////////////////////////////////
using namespace tt;

std::tuple<tt_metal::Program, tt_metal::KernelID, tt_metal::KernelID> create_program(
std::tuple<tt_metal::Program, tt_metal::KernelHandle, tt_metal::KernelHandle> create_program(
tt_metal::Device *device,
uint32_t single_tile_size,
const CoreRange &all_cores,
Expand Down Expand Up @@ -87,7 +87,7 @@ void compile_and_configure_program(

}

void set_rt_args(tt_metal::Program &program, tt_metal::KernelID kernel, const CoreRange &core_range, const std::vector<uint32_t> &rt_args) {
void set_rt_args(tt_metal::Program &program, tt_metal::KernelHandle kernel, const CoreRange &core_range, const std::vector<uint32_t> &rt_args) {
for (auto x = core_range.start.x; x <= core_range.end.x; x++) {
for (auto y = core_range.start.y; y <= core_range.end.y; y++) {
CoreCoord core = CoreCoord(x, y);
Expand All @@ -99,8 +99,8 @@ void set_rt_args(tt_metal::Program &program, tt_metal::KernelID kernel, const Co
void write_same_runtime_args_to_device(
tt_metal::Device *device,
tt_metal::Program &program,
tt_metal::KernelID reader_kernel_id,
tt_metal::KernelID writer_kernel_id,
tt_metal::KernelHandle reader_kernel_id,
tt_metal::KernelHandle writer_kernel_id,
const CoreRange &core_range,
int32_t num_tiles,
tt_metal::Buffer &src_dram_buffer,
Expand Down Expand Up @@ -129,8 +129,8 @@ void write_same_runtime_args_to_device(
void write_unique_writer_runtime_args_to_device(
tt_metal::Device *device,
tt_metal::Program &program,
tt_metal::KernelID reader_kernel_id,
tt_metal::KernelID writer_kernel_id,
tt_metal::KernelHandle reader_kernel_id,
tt_metal::KernelHandle writer_kernel_id,
const CoreRange &core_range,
const CoreRangeSet &core_blocks,
int32_t num_tiles,
Expand Down
8 changes: 4 additions & 4 deletions tests/tt_metal/tt_metal/test_multiple_programs.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ std::map<string, string> get_defines(BinaryOpType::Enum op_type){
}


std::tuple<tt_metal::Program, tt_metal::KernelID, tt_metal::KernelID> setup_program_one(tt_metal::Device *device, const CoreCoord &core, uint32_t single_tile_size) {
std::tuple<tt_metal::Program, tt_metal::KernelHandle, tt_metal::KernelHandle> setup_program_one(tt_metal::Device *device, const CoreCoord &core, uint32_t single_tile_size) {
tt_metal::Program program = tt_metal::CreateProgram();

uint32_t src0_cb_index = 0;
Expand Down Expand Up @@ -88,7 +88,7 @@ std::tuple<tt_metal::Program, tt_metal::KernelID, tt_metal::KernelID> setup_prog
return {std::move(program), binary_reader_kernel, unary_writer_kernel};
}

std::tuple<tt_metal::Program, tt_metal::KernelID, tt_metal::KernelID> setup_program_two(tt_metal::Device *device, const CoreCoord &core, uint32_t single_tile_size) {
std::tuple<tt_metal::Program, tt_metal::KernelHandle, tt_metal::KernelHandle> setup_program_two(tt_metal::Device *device, const CoreCoord &core, uint32_t single_tile_size) {
tt_metal::Program program = tt_metal::CreateProgram();

uint32_t src0_cb_index = 0;
Expand Down Expand Up @@ -143,8 +143,8 @@ std::tuple<tt_metal::Program, tt_metal::KernelID, tt_metal::KernelID> setup_prog
void write_program_runtime_args_to_device(
tt_metal::Device *device,
tt_metal::Program &program,
tt_metal::KernelID reader_kernel_id,
tt_metal::KernelID writer_kernel_id,
tt_metal::KernelHandle reader_kernel_id,
tt_metal::KernelHandle writer_kernel_id,
const CoreCoord &core,
uint32_t num_tiles,
tt_metal::Buffer &src0_dram_buffer,
Expand Down
2 changes: 1 addition & 1 deletion tests/tt_metal/tt_metal/unit_tests/basic/device.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ TEST_F(DeviceFixture, ValidateKernelDoesNotTargetHarvestedCores) {
CoreCoord logical_target_core = CoreCoord({.x = 0, .y = 0});
uint32_t intermediate_l1_addr = L1_UNRESERVED_BASE;
uint32_t size_bytes = host_input.size() * sizeof(uint32_t);
tt_metal::KernelID kernel_id = tt_metal::CreateKernel(
tt_metal::KernelHandle kernel_id = tt_metal::CreateKernel(
program,
kernel_name,
logical_target_core,
Expand Down
8 changes: 4 additions & 4 deletions tests/tt_metal/tt_metal/unit_tests/circular_buffer/test_CircularBuffer_allocation.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ TEST_F(DeviceFixture, TestValidUpdateCircularBufferSize) {

const uint32_t core0_num_cbs = 2;
std::map<CoreCoord, std::map<uint8_t, uint32_t>> golden_addresses_per_core;
std::vector<CircularBufferID> cb_ids;
std::vector<CBHandle> cb_ids;
auto expected_cb_addr = L1_UNRESERVED_BASE;
for (uint32_t buffer_idx = 0; buffer_idx < core0_num_cbs; buffer_idx++) {
CircularBufferConfig config1 = CircularBufferConfig(cb_config.page_size, {{buffer_idx, cb_config.data_format}}).set_page_size(buffer_idx, cb_config.page_size);
Expand Down Expand Up @@ -213,7 +213,7 @@ TEST_F(DeviceFixture, TestInvalidUpdateCircularBufferSize) {

const uint32_t core0_num_cbs = 2;
std::map<CoreCoord, std::map<uint8_t, uint32_t>> golden_addresses_per_core;
std::vector<CircularBufferID> cb_ids;
std::vector<CBHandle> cb_ids;
auto expected_cb_addr = L1_UNRESERVED_BASE;
for (uint32_t buffer_idx = 0; buffer_idx < core0_num_cbs; buffer_idx++) {
CircularBufferConfig config1 = CircularBufferConfig(cb_config.page_size, {{buffer_idx, cb_config.data_format}}).set_page_size(buffer_idx, cb_config.page_size);
Expand Down Expand Up @@ -246,7 +246,7 @@ TEST_F(DeviceFixture, TestUpdateCircularBufferAddress) {

const uint32_t core0_num_cbs = 2;
std::map<CoreCoord, std::map<uint8_t, uint32_t>> golden_addresses_per_core;
std::vector<CircularBufferID> cb_ids;
std::vector<CBHandle> cb_ids;
auto expected_cb_addr = L1_UNRESERVED_BASE;
for (uint32_t buffer_idx = 0; buffer_idx < core0_num_cbs; buffer_idx++) {
CircularBufferConfig config1 = CircularBufferConfig(cb_config.page_size, {{buffer_idx, cb_config.data_format}}).set_page_size(buffer_idx, cb_config.page_size);
Expand Down Expand Up @@ -277,7 +277,7 @@ TEST_F(DeviceFixture, TestUpdateCircularBufferPageSize) {
const uint32_t core0_num_cbs = 2;
std::map<CoreCoord, std::map<uint8_t, uint32_t>> golden_addresses_per_core;
std::map<CoreCoord, std::map<uint8_t, uint32_t>> golden_num_pages_per_core;
std::vector<CircularBufferID> cb_ids;
std::vector<CBHandle> cb_ids;
auto expected_cb_addr = L1_UNRESERVED_BASE;
for (uint32_t buffer_idx = 0; buffer_idx < core0_num_cbs; buffer_idx++) {
CircularBufferConfig config1 = CircularBufferConfig(cb_config.page_size, {{buffer_idx, cb_config.data_format}}).set_page_size(buffer_idx, cb_config.page_size);
Expand Down
2 changes: 1 addition & 1 deletion tests/tt_metal/tt_metal/unit_tests_fast_dispatch/command_queue/test_EnqueueProgram.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ bool test_dummy_EnqueueProgram_with_cbs_update_size(Device* device, CommandQueue
Program program;


std::vector<CircularBufferID> cb_ids;
std::vector<CBHandle> cb_ids;
for (uint32_t i = 0; i < program_config.cb_config_vector.size(); i++) {
uint32_t cb_id = program_config.cb_config_vector[i].cb_id;
uint32_t cb_num_pages = program_config.cb_config_vector[i].num_pages;
Expand Down
Loading

0 comments on commit 882fe5f

Please sign in to comment.