#2934: Add check that expects num host channels for a mmio device to …

…be number of chips on a card and run multi cq device fixture on GS
tenstorrent · Dec 6, 2023 · 4d34b98 · 4d34b98
1 parent fbfc617
commit 4d34b98
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/tests/tt_metal/tt_metal/unit_tests/basic/device.cpp b/tests/tt_metal/tt_metal/unit_tests/basic/device.cpp
@@ -351,6 +351,7 @@ TEST_F(DeviceFixture, TestDeviceToHostMemChannelAssignment) {
     }
 
     for (const auto& [mmio_dev_id, device_group] : mmio_device_to_device_group) {
+        EXPECT_EQ(tt::Cluster::instance().get_num_host_channels(mmio_dev_id), device_group.size());
         EXPECT_EQ(tt::Cluster::instance().get_assigned_channel_for_device(mmio_dev_id), 0);
         std::unordered_set<uint16_t> channels;
         for (const chip_id_t &device_id : device_group) {

diff --git a/tests/tt_metal/tt_metal/unit_tests_fast_dispatch/command_queue/test_CommandQueue.cpp b/tests/tt_metal/tt_metal/unit_tests_fast_dispatch/command_queue/test_CommandQueue.cpp
@@ -11,6 +11,7 @@
 #include "tt_metal/detail/tt_metal.hpp"
 #include "tt_metal/test_utils/env_vars.hpp"
 #include "tt_metal/test_utils/stimulus.hpp"
+#include "tt_metal/test_utils/print_helpers.hpp"
 
 using namespace tt::tt_metal;
 
@@ -52,7 +53,7 @@ TEST_F(MultiCommandQueueFixture, TestDirectedLoopbackToUniqueHugepage) {
     for (chip_id_t device_id = 0; device_id < num_devices_; device_id++) {
         chip_id_t mmio_device_id = tt::Cluster::instance().get_associated_mmio_device(device_id);
         uint16_t channel = tt::Cluster::instance().get_assigned_channel_for_device(device_id);
-        tt::Cluster::instance().read_sysmem(&readback_data, byte_size, address, mmio_device_id, channel);
+        tt::Cluster::instance().read_sysmem(readback_data.data(), byte_size, address, mmio_device_id, channel);
         EXPECT_EQ(readback_data, golden_data.at(device_id));
     }
 }

diff --git a/tests/tt_metal/tt_metal/unit_tests_fast_dispatch/common/command_queue_fixture.hpp b/tests/tt_metal/tt_metal/unit_tests_fast_dispatch/common/command_queue_fixture.hpp
@@ -109,10 +109,6 @@ class MultiCommandQueueFixture : public ::testing::Test {
 
         num_devices_ = tt::tt_metal::Device::detect_num_available_devices();
 
-        if (arch_ == tt::ARCH::GRAYSKULL && num_devices_ > 1) {
-            GTEST_SKIP();
-        }
-
         for (unsigned int id = 0; id < num_devices_; id++) {
             auto* device = tt::tt_metal::CreateDevice(id);
             devices_.push_back(device);