#8114: Properly declare tt_eager/queue lib before tt_eager/tensor and…

… tt_dnn and put it as a dependency for tt_eager/tensor, as you could've seen this error when doing make build && make tests
tenstorrent · May 13, 2024 · 37862d7 · 37862d7
1 parent 98646cf
commit 37862d7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -96,7 +96,7 @@ jobs:
       # So we can get all the makefile output we want
       SILENT: 0
     runs-on: ${{ matrix.config.runs-on }}
-    name: build ${{ matrix.config.type }} ${{ matrix.arch }}
+    name: make build ${{ matrix.config.type }} ${{ matrix.arch }}
     steps:
       - uses: actions/checkout@v4
         with:
@@ -131,7 +131,7 @@ jobs:
         arch: [grayskull, wormhole_b0]
         os: [ubuntu-20.04]
     needs: build-lib
-    name: build cpptest ${{ matrix.config }} ${{ matrix.arch }}
+    name: make build cpptest ${{ matrix.config }} ${{ matrix.arch }}
     env:
       ARCH_NAME: ${{ matrix.arch }}
       CONFIG: ${{ matrix.config }}

diff --git a/tt_eager/module.mk b/tt_eager/module.mk
@@ -5,9 +5,9 @@ EAGER_OUTPUT_DIR = $(OUT)/dist
 
 TT_EAGER_INCLUDES = $(TT_METAL_BASE_INCLUDES) -Itt_eager/ -I ttnn/cpp/
 
+include tt_eager/queue/module.mk
 include tt_eager/tensor/module.mk
 include tt_eager/tt_dnn/module.mk
-include tt_eager/queue/module.mk
 include tt_eager/tt_lib/module.mk
 
 TT_LIBS_TO_BUILD = tt_eager/tensor \

diff --git a/tt_eager/tensor/module.mk b/tt_eager/tensor/module.mk
@@ -19,7 +19,7 @@ TENSOR_DEPS = $(addprefix $(OBJDIR)/, $(TENSOR_SRCS:.cpp=.d))
 # Each module has a top level target as the entrypoint which must match the subdir name
 tt_eager/tensor: $(TENSOR_LIB)
 
-$(TENSOR_LIB): $(COMMON_LIB) $(TT_METAL_LIB) $(TENSOR_OBJS)
+$(TENSOR_LIB): $(COMMON_LIB) $(TT_METAL_LIB) $(TENSOR_OBJS) $(QUEUE_LIB)
 	@mkdir -p $(LIBDIR)
 	ar rcs -o $@ $(TENSOR_OBJS)