-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Mock Model + Test Directory #24
Adding Mock Model + Test Directory #24
Conversation
It's confusing at the moment having two sets of code changes where one is a copy of #21. Hard to see which code pieces you would like the focus of the review on. My recommendation is either:
|
This makes sense, I'll add that to enable making changes that require other unmerged changes on another branch we shouldnt merge onto the other branch as the default but wait until that branch is merged to
|
b87ae57
to
7a92a47
Compare
46a935e
to
c0acf71
Compare
4dc87cd
to
bf2e08b
Compare
Co-authored-by: Milan Kordic <[email protected]>
@mvanniasingheTT I think the code could benefit by running a formatter and linter. Consider the Ruff VSCode extension as an easy plugin to run. CC: @tstescoTT |
Co-authored-by: Milan Kordic <[email protected]>
Co-authored-by: Milan Kordic <[email protected]>
…rent/tt-inference-server into mvanniasinghe/mock_model
…lways set to call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Pending the merge of #21.
@mvanniasingheTT I think that you forgot to change the target branch? |
This reverts commit 9bb28d0.
This PR adds in the mock model + mock offline inference script + a new test directory.
The mock model can be used for quick iteration and development without a TT device to test benchmarking/stress-testing/eval procedures in either an online or offline setting.