Add xfail to resnet and llama mlp #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilkicTT
approved these changes
Nov 14, 2024
|
@pilkicTT @nvukobratTT I would like to merge it as soon as the CI passes. |
Go free |
dgolubovicTT
deleted the
dgolubovic/add-xfail-on-llama-mlp-and-resnet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR I removed xfail from
test_llama_mlpbecause it had worked on main at the time. I rebased and merged immediately. Unfortunately, somewhere in between test started failing. Thus, returning xfail until I investigate.Also adding xfail for resnet inference with known issue that is being addressed on metal