Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] removing xfail in test_ops.py #693

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[test] removing xfail in test_ops.py #693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions forge/test/mlir/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ def get_input_tensor(dtype):
(1, 7, 256),
],
)
@pytest.mark.xfail(reason="Found Unsupported operations while lowering from TTForge to TTIR in forward graph")
@pytest.mark.push
def test_sin(shape):
class sin(nn.Module):
Expand Down Expand Up @@ -158,7 +157,6 @@ def forward(self, x):
(1, 7, 256),
],
)
@pytest.mark.xfail(reason="Found Unsupported operations while lowering from TTForge to TTIR in forward graph")
@pytest.mark.push
def test_cosine(shape):
class cosine(nn.Module):
Expand Down Expand Up @@ -1070,9 +1068,6 @@ def forward(self, x, y):
assert compare_with_golden_pcc(golden=fw_out, calculated=co_out[0], pcc=0.99)


@pytest.mark.xfail(
reason="Unable to reshape a tensor in TILE_LAYOUT to non-tile height and width! Please convert the tensor to ROW_MAJOR_LAYOUT first"
)
@pytest.mark.parametrize("x_shape", [7, 32, 41])
@pytest.mark.parametrize("y_shape", [7, 32, 41])
@pytest.mark.parametrize("dim", [1, 2])
Expand All @@ -1085,6 +1080,11 @@ def __init__(self):
def forward(self, x):
return torch.mean(x, dim=dim)

if dim == 1 and y_shape == 32:
pytest.xfail(
"TTNN: tilize fails for float32 - will be fixed once a080e2f035990d57ce5436a8affb3f052a5a1b5f in tt-metal is consumed"
)

inputs = [
torch.rand(1, x_shape, y_shape),
]
Expand Down
Loading