Skip to content

Commit

Permalink
[test] removing xfail in test_ops.py (#693)
Browse files Browse the repository at this point in the history
I've noticed some tests are now passing (with latest tt-mlir/tt-metal),
so removing `xfail` mark for those.
  • Loading branch information
pilkicTT authored Nov 14, 2024
1 parent e6c6907 commit f4352fd
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions forge/test/mlir/test_ops.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ def get_input_tensor(dtype):
(1, 7, 256),
],
)
@pytest.mark.xfail(reason="Found Unsupported operations while lowering from TTForge to TTIR in forward graph")
@pytest.mark.push
def test_sin(shape):
class sin(nn.Module):
Expand Down Expand Up @@ -158,7 +157,6 @@ def forward(self, x):
(1, 7, 256),
],
)
@pytest.mark.xfail(reason="Found Unsupported operations while lowering from TTForge to TTIR in forward graph")
@pytest.mark.push
def test_cosine(shape):
class cosine(nn.Module):
Expand Down Expand Up @@ -1070,9 +1068,6 @@ def forward(self, x, y):
assert compare_with_golden_pcc(golden=fw_out, calculated=co_out[0], pcc=0.99)


@pytest.mark.xfail(
reason="Unable to reshape a tensor in TILE_LAYOUT to non-tile height and width! Please convert the tensor to ROW_MAJOR_LAYOUT first"
)
@pytest.mark.parametrize("x_shape", [7, 32, 41])
@pytest.mark.parametrize("y_shape", [7, 32, 41])
@pytest.mark.parametrize("dim", [1, 2])
Expand All @@ -1085,6 +1080,11 @@ def __init__(self):
def forward(self, x):
return torch.mean(x, dim=dim)

if dim == 1 and y_shape == 32:
pytest.xfail(
"TTNN: tilize fails for float32 - will be fixed once a080e2f035990d57ce5436a8affb3f052a5a1b5f in tt-metal is consumed"
)

inputs = [
torch.rand(1, x_shape, y_shape),
]
Expand Down

0 comments on commit f4352fd

Please sign in to comment.