Add CMSIS-NN int8 and int16 batch matmul #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moves some common functions with ref to new header file * Creates new cmsis_nn batch_matmul.cc Signed-off-by: Ryan O'Shea <[email protected]> Co-authored-by: Adrian Lundell <[email protected]> Change-Id: I88de8284bb10abaebf7b649436c5375474e1d44d
suleshahid
reviewed
Aug 27, 2024
| @@ -271,22 +204,14 @@ TfLiteStatus TransposeRowsColumns(const TfLiteEvalTensor& tensor_in, | |||
| return kTfLiteError; | |||
There was a problem hiding this comment.
TransposeRowsColumns and TransposeRowsColumnsImpl is moved to the header file right? We should de-dupe from here?
There was a problem hiding this comment.
Nice catch, should be fixed now 😄
Signed-off-by: Ryan O'Shea <[email protected]>
suleshahid
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored-by: Ryan O'Shea [email protected]
Co-authored-by: Adrian Lundell [email protected]
BUG=Add BatchMatmul kernels to cmsisnn