Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert requirement of tensorflow-macos package for MacOS platforms #745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marygiotandoi
Copy link

@marygiotandoi marygiotandoi commented Nov 13, 2024

Hi,

In a previous PR, tensorflow-macos was added as a dependency to enable installing newer versions of tensorflow-recommenders on MacOS-machines, as the package requires tensorflow >= 2.9.0 and at that time it did not exist for macos. This was included in the 0.7.3 release.

With TensorFlow 2.16.1, Apple Silicon users are now advised to install TensorFlow via pip install tensorflow. Due to this change, installing the latest tensorflow-recommenders via poetry fails with a dependency error (Package 'tensorflow-macos' is listed as a dependency of itself), as reported in issue #713.

This PR reverts the changes from PR #549 to resolve the issue.

Revert requirement of tensorflow-macos package for MacOS platforms
Copy link

google-cla bot commented Nov 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@marygiotandoi marygiotandoi changed the title Update requirements.txt Revert requirement of tensorflow-macos package for MacOS platforms Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant