Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid requiring static shapes for Size and Split ops #757

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Avoid requiring static shapes for Size and Split ops #757

wants to merge 5 commits into from

Conversation

adk9
Copy link
Contributor

@adk9 adk9 commented Dec 16, 2020

Avoid usage of get_shape() in Size and Split op so that they can work for dynamic inputs

Abhishek Kulkarni added 2 commits December 15, 2020 22:59
Fix Size translation to support dynamic inputs
2405e06 
Size translation calls get_shape() which doesn't work on dynamic inputs.
Fix the Size translation by computing size at runtime.
Avoid fixing negative dims in Split since it's handled by IE
08bd3fb
@adk9 adk9 self-assigned this Dec 16, 2020
@adk9 adk9 marked this pull request as draft December 16, 2020 17:27
@adk9 adk9 marked this pull request as ready for review December 17, 2020 02:10
@adk9 adk9 added wip Work in progress comp:core Bridge core labels Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanvi-nervana kanvi-nervana Awaiting requested review from kanvi-nervana

@bani-intelaipg bani-intelaipg Awaiting requested review from bani-intelaipg

At least 1 approving review is required to merge this pull request.

Assignees

@adk9 adk9

Labels
comp:core Bridge core wip Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adk9