Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix build #277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

72 changes: 72 additions & 0 deletions flake.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
{
description = "Haskell bindings for TensorFlow";

inputs = {
nixpkgs.url = "nixpkgs/nixpkgs-unstable";

flake-utils.url = "github:numtide/flake-utils";

flake-compat = {
url = "github:edolstra/flake-compat";
flake = false;
};

tensorflowSubModule = {
url =
"github:tensorflow/tensorflow/b36436b087bd8e8701ef51718179037cccdfc26e";
flake = false;
};
};

outputs = { self, nixpkgs, flake-utils, tensorflowSubModule, ... }:
flake-utils.lib.eachSystem [ "x86_64-linux" ] (system:
let
pkgs = import nixpkgs {
inherit system;
overlays = [ (import ./nix/overlay.nix tensorflowSubModule) ];
};

tfPackages = [
"tensorflow"
"tensorflow-core-ops"
"tensorflow-logging"
"tensorflow-opgen"
"tensorflow-ops"
"tensorflow-proto"
"tensorflow-records"
"tensorflow-records-conduit"
"tensorflow-test"
];

in {
packages = builtins.listToAttrs (builtins.map (p: {
name = p;
value = pkgs.haskellPackages."${p}";
}) tfPackages);

devShells = let
devDeps = with pkgs; [
cabal-install
haskell-language-server
hlint
ormolu
];

devPkgs = builtins.listToAttrs (builtins.map (p: {
name = p;
value = pkgs.mkShell {
buildInputs = let
pkgEnv = pkgs.haskellPackages.ghcWithPackages (ghcPkgs:
ghcPkgs."${p}".buildInputs
++ ghcPkgs."${p}".propagatedBuildInputs
++ ghcPkgs."${p}".propagatedNativeBuildInputs
++ ghcPkgs."${p}".nativeBuildInputs ++ devDeps);
in [ pkgEnv ];
};
}) tfPackages);

in devPkgs // { default = devPkgs.tensorflow; };
}) // {
overlays.default = import ./nix/overlay.nix tensorflowSubModule;
};
}
78 changes: 78 additions & 0 deletions nix/overlay.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
tensorflowSubModule: final: prev:

let
/* The tensorflow submodule in third_party/tensorflow and the symlinks in the
Haskell-package directories will always be removed by Nix.
Thus construct a source here where the submodule is a normal directory
whenever required.
*/
tfSrc = prev.runCommand "prepTensorflowSrc" {
src = prev.nix-gitignore.gitignoreSource [
"nix/"
"flake.nix"
"flake.lock"
"result"
] ./..;
} ''
cp -r $src/* .

chmod -R +rwx ./third_party
cp -r ${tensorflowSubModule} ./third_party/tensorflow
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't see a good option to get Nix accepting the submodules, it would be nice to use prev.libtensorflow.src instead tensorflowSubModule, so that the correct version also used in nixpkgs is provided. libtensorflow-2.9.1 from current nixpkgs gives compilation errors, however.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no opinion about this as I don't understand Nix enough and we have no CI around that. Fix it to your liking?


chmod -R +rwx tensorflow
rm -rf tensorflow/third_party
cp -r ${tensorflowSubModule} ./tensorflow/third_party

for d in tensorflow-opgen tensorflow-proto; do
chmod +rwx $d $d/third_party
rm -rf $d/third_party
mkdir $d/third_party
cp -r ${tensorflowSubModule} $d/third_party/tensorflow
done
cp -r . $out
'';

haskellOverrides = final: prev: hfinal: hprev: {
tensorflow = hfinal.callCabal2nix "tensorflow" "${tfSrc}/tensorflow" { };

tensorflow-core-ops =
hfinal.callCabal2nix "tensorflow-core-ops" "${tfSrc}/tensorflow-core-ops"
{ };

tensorflow-logging =
hfinal.callCabal2nix "tensorflow-logging" "${tfSrc}/tensorflow-logging"
{ };

tensorflow-opgen =
hfinal.callCabal2nix "tensorflow-opgen" "${tfSrc}/tensorflow-opgen" { };

tensorflow-ops =
hfinal.callCabal2nix "tensorflow-ops" "${tfSrc}/tensorflow-ops" { };

tensorflow-proto = let
c2n =
hfinal.callCabal2nix "tensorflow-proto" "${tfSrc}/tensorflow-proto" { };
in prev.haskell.lib.overrideCabal c2n (drv: {
libraryToolDepends = drv.libraryToolDepends ++ [ prev.protobuf ];
});

tensorflow-records =
hfinal.callCabal2nix "tensorflow-records" "${tfSrc}/tensorflow-records"
{ };

tensorflow-records-conduit =
hfinal.callCabal2nix "tensorflow-records-conduit"
"${tfSrc}/tensorflow-records-conduit" { };

tensorflow-test =
hfinal.callCabal2nix "tensorflow-test" "${tfSrc}/tensorflow-test" { };
};

in {
haskell = prev.haskell // {
packages = prev.haskell.packages // (builtins.mapAttrs
(key: val: val.override { overrides = haskellOverrides final prev; }) {
inherit (prev.haskell.packages) ghc8107 ghc902 ghc923;
});
};
}
6 changes: 0 additions & 6 deletions nix/src.json

This file was deleted.

26 changes: 0 additions & 26 deletions nix/update

This file was deleted.