-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature-windows_support #164
Feature-windows_support #164
Conversation
Why this become draft sir? |
Because it is not done. |
@PaulTR This is now working for me locally. One thing that should be added is how to compile the TF Lite binary on Windows. Following the procedure linked in the README I only get a debug binary. @PaulTR @moshOntong-IT any ideas? |
@PaulTR many of the new examples added after the macos pr have quite a few problems when running |
@st-duymai Hey Duy, would you mind checking into the Thanks! |
Hi @PaulTR , @CaptainDario Since this project uses Melos to manage project, you must run
I will test it tomorrow on my Windows machine at home. |
@PaulTR @CaptainDario I have tested all of the above apps, and they all work except for the features related to the camera and recording audio. Two projects, live_object_detection_ssd_mobile_net and audio_classification, do not work completely because they are not implemented for Windows. I think that we should remove the Windows package from these two projects. |
Sounds good. Yeah camera isn't expected to work for desktop (just isn't supported generally by Flutter from what I understand). I'm not sure if a similar limitation exists for audio - if audio can be supported, that'd be awesome, but I'm not too worried about it, so cleaning that up would be perfect and then we can get this merged. Thanks for the heads up on Melos! As for the binaries, I'm not sure if there's a difference in release vs debug ones? I'm only aware of the one set of docs for creating them. If there's something blocking with that though I can definitely bubble it up to eng. |
resolve conv
With the audio example, I do not know how it works. It is calling some platform code that does not work on Mac, Linux, Windows. However, I added to each README which platforms are supported, I thought that should work. Example for audio: In regards to the binaries, for me the confusing thing is, that on Mac and Linux it does not create a debug binary by default. I think it is really confusing, but maybe that's only me. |
This PR should add windows support.
Environment:
Changes:
Notes:
Progress: