Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-windows_support #164

Merged
merged 28 commits into from
Nov 19, 2023
Merged

Conversation

CaptainDario
Copy link
Contributor

@CaptainDario CaptainDario commented Oct 23, 2023

This PR should add windows support.

Environment:

  • Windows 10

Changes:

  • Load TF Lite binary
  • update examples (same as macos, linux) to support windows

Notes:

  • Camera is disabled for the examples on desktop as this is not really supported

Progress:

  • load TF Lite on windows
  • test examples
    • audio classification
      • uses some platform channels that do not work on windows
    • image classification mobilenet
      • only from file works
    • live object detection ssd mobile net
      • uses camera package that only works on mobile
    • object detection ssd mobile net
      • only from file works
    • style transfer
      • works
    • super resolution esrgan
      • works
    • text classification
      • works

@CaptainDario CaptainDario marked this pull request as draft October 23, 2023 20:54
@moshOntong-IT
Copy link

Why this become draft sir?

@CaptainDario
Copy link
Contributor Author

Because it is not done.

@CaptainDario CaptainDario marked this pull request as ready for review November 10, 2023 15:21
@CaptainDario
Copy link
Contributor Author

@PaulTR This is now working for me locally.

One thing that should be added is how to compile the TF Lite binary on Windows. Following the procedure linked in the README I only get a debug binary. @PaulTR @moshOntong-IT any ideas?

@CaptainDario
Copy link
Contributor Author

@PaulTR many of the new examples added after the macos pr have quite a few problems when running flutter analyze .

@PaulTR
Copy link
Collaborator

PaulTR commented Nov 10, 2023

@st-duymai Hey Duy, would you mind checking into the flutter analyze issue on the samples? This PR is also ready for testing it looks like.

Thanks!

@ghost
Copy link

ghost commented Nov 13, 2023

Hi @PaulTR , @CaptainDario Since this project uses Melos to manage project, you must run dart pub global activate melos and melos bootstrap before flutter analyze .. Run flutter analyze . without melos can causes missing dependencies and locally linking package issue.

This PR is also ready for testing it looks like.

I will test it tomorrow on my Windows machine at home.

@ghost
Copy link

ghost commented Nov 14, 2023

@PaulTR @CaptainDario I have tested all of the above apps, and they all work except for the features related to the camera and recording audio. Two projects, live_object_detection_ssd_mobile_net and audio_classification, do not work completely because they are not implemented for Windows. I think that we should remove the Windows package from these two projects.

README.md Outdated Show resolved Hide resolved
@PaulTR
Copy link
Collaborator

PaulTR commented Nov 14, 2023

@PaulTR @CaptainDario I have tested all of the above apps, and they all work except for the features related to the camera and recording audio. Two projects, live_object_detection_ssd_mobile_net and audio_classification, do not work completely because they are not implemented for Windows. I think that we should remove the Windows package from these two projects.

Sounds good. Yeah camera isn't expected to work for desktop (just isn't supported generally by Flutter from what I understand). I'm not sure if a similar limitation exists for audio - if audio can be supported, that'd be awesome, but I'm not too worried about it, so cleaning that up would be perfect and then we can get this merged.

Thanks for the heads up on Melos!

As for the binaries, I'm not sure if there's a difference in release vs debug ones? I'm only aware of the one set of docs for creating them. If there's something blocking with that though I can definitely bubble it up to eng.

resolve conv
@CaptainDario
Copy link
Contributor Author

With the audio example, I do not know how it works. It is calling some platform code that does not work on Mac, Linux, Windows. However, I added to each README which platforms are supported, I thought that should work.

Example for audio:

image

In regards to the binaries, for me the confusing thing is, that on Mac and Linux it does not create a debug binary by default. I think it is really confusing, but maybe that's only me.

@PaulTR PaulTR merged commit 4013d48 into tensorflow:main Nov 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants