Merge pull request #374 from Infinoid/python-warnings

Fix warnings in python bindings
tensor-compiler · Jan 20, 2021 · bc5a580 · bc5a580
2 parents fda53cd + 6936727
commit bc5a580
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/python_bindings/pybind11/include/pybind11/detail/common.h b/python_bindings/pybind11/include/pybind11/detail/common.h
@@ -648,7 +648,7 @@ inline void ignore_unused(const int *) { }
 #define PYBIND11_EXPAND_SIDE_EFFECTS(PATTERN) (((PATTERN), void()), ...)
 #else
 using expand_side_effects = bool[];
-#define PYBIND11_EXPAND_SIDE_EFFECTS(PATTERN) pybind11::detail::expand_side_effects{ ((PATTERN), void(), false)..., false }
+#define PYBIND11_EXPAND_SIDE_EFFECTS(PATTERN) (void)pybind11::detail::expand_side_effects{ ((PATTERN), void(), false)..., false }
 #endif
 
 NAMESPACE_END(detail)

diff --git a/python_bindings/pybind11/include/pybind11/detail/internals.h b/python_bindings/pybind11/include/pybind11/detail/internals.h
@@ -197,7 +197,10 @@ PYBIND11_NOINLINE inline internals &get_internals() {
         auto *&internals_ptr = *internals_pp;
         internals_ptr = new internals();
 #if defined(WITH_THREAD)
-        PyEval_InitThreads();
+
+#       if PY_VERSION_HEX < 0x03090000
+            PyEval_InitThreads();
+#       endif
         PyThreadState *tstate = PyThreadState_Get();
         #if PY_VERSION_HEX >= 0x03070000
             internals_ptr->tstate = PyThread_tss_alloc();