Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix websockets not connecting via secure wss #2195

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Dec 11, 2024

Why this change is needed

After using separate domains for backend and frontend we are connecting to the backend directly (to VM) and the traffic doesn't go through Azure Application Gateway anymore. This gateway was handling TLS termination for websockets before.

What changes were made as part of this PR

  • Using wss in case we have TLSConfig and https connection
  • Using the same port for wss and https as is the standard

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Contributor

@moraygrieve moraygrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zkokelj zkokelj merged commit a97daec into main Dec 11, 2024
4 checks passed
@zkokelj zkokelj deleted the ziga/fix_websocket_wss_issue branch December 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants