Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove balance of message bus for burned native value. #2192

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

StefanIliev545
Copy link
Contributor

Why this change is needed

In order to have better book keeping on the message bus, the native transfers that get sent back to l1 need to be burned (as they are minted when they are inbound)

What changes were made as part of this PR

A new function in the batch executor that goes over the transfers and burns the value.

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs clarifying comment(s)

go/enclave/components/batch_executor.go Show resolved Hide resolved
Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanIliev545 StefanIliev545 merged commit e5fe097 into main Dec 9, 2024
2 checks passed
@StefanIliev545 StefanIliev545 deleted the siliev/reduce-balance-of-bus branch December 9, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants