-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set message bus fee in a deployment script for testnet. #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanIliev545
temporarily deployed
to
dev-testnet
December 10, 2024 11:00 — with
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
December 10, 2024 11:14 — with
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
December 10, 2024 11:14 — with
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
December 10, 2024 11:14 — with
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
December 10, 2024 11:22 — with
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
December 10, 2024 11:23 — with
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
December 10, 2024 11:23 — with
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
December 10, 2024 11:23 — with
GitHub Actions
Inactive
StefanIliev545
temporarily deployed
to
dev-testnet
December 10, 2024 11:27 — with
GitHub Actions
Inactive
tudor-malene
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment.
LGTM
import { network } from 'hardhat'; | ||
|
||
/* | ||
This script deploys the ZenTestnet contract on the l2 and whitelists it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this comment accurate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Currently the fee is 0 and is nevert set. This enables it on testnet.
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks