Batch execution refactor #2186
Merged
Batch execution refactor #2186
+395
−351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| ec.blockEndResult = onBlockTxResult | ||
| ec.blockEndResult.MarkSynthetic(true) | ||
| // todo - stefan not clear what this does |
There was a problem hiding this comment.
Some paranoia checks I've added; Not sure if we really need them
tudor-malene
changed the title
StefanIliev545
approved these changes
Dec 6, 2024
| args = append(args, senders[i]) // sender_address | ||
| args = append(args, i) // idx | ||
| args = append(args, senderIds[i]) // sender_address | ||
| args = append(args, fromIdx+i) // idx |
There was a problem hiding this comment.
I take it this was wrong value previously
There was a problem hiding this comment.
I'm not sure about the offsets that were passed to the tx execution either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
To help fix a bug that returns phantom events.
What changes were made as part of this PR
receipt.txto the transaction table, because now wePR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks