-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2247 flag clean v2 #1896
Draft
anixon604
wants to merge
59
commits into
main
Choose a base branch
from
anthony/2247-flag-clean-v2-Merger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
2247 flag clean v2 #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go/config/enclave_cli_flags.go # go/config/enclave_config.go # go/config/host_config.go # go/enclave/enclave.go # go/enclave/rpc/EstimateGas.go # go/host/container/cli.go # go/host/container/cli_flags.go # go/node/cmd/cli.go # go/node/cmd/cli_flags.go # go/node/cmd/main.go # go/node/config.go # go/node/docker_node.go # integration/common/constants.go
Need to add serialization of derived Host / Enclave configs to pass in via |
…er enclave via signed config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
This is a second iteration
Reduce complexity of configuration of sub-services and aggregate node / testnet configs.
Default template bases and static config overrides to enable reliable and debuggable instances.
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks