Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract addresses: Have host fetch L2 Msg Bus address from enclave #1669

Merged
merged 5 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions go/common/enclave.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ type EnclaveScan interface {

// GetPublicTransactionData returns a list of public transaction data
GetPublicTransactionData(pagination *QueryPagination) (*TransactionListingResponse, SystemError)

// GetL2MessageBusAddress returns the address of the L2 message bus contract
GetL2MessageBusAddress() (gethcommon.Address, SystemError)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new function GetL2MessageBusAddress should have a comment explaining its purpose, parameters, and return values, as it is an exported function and part of an interface.

}

// BlockSubmissionResponse is the response sent from the enclave back to the node after ingesting a block
Expand Down
1 change: 1 addition & 0 deletions go/common/query_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,6 @@ type ObscuroNetworkInfo struct {
L1StartHash common.Hash
SequencerID common.Address
MessageBusAddress common.Address
L2MessageBusAddress common.Address
ImportantContracts map[string]common.Address // map of contract name to address
}
Loading
Loading