Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wallet extension endpoints #1641

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Nov 13, 2023

Why this change is needed

Old wallet extension endpoints are no longer used and are insecure on the hosted gateway.

What changes were made as part of this PR

  • Old endpoints removed
  • Tests moved to integration tests (keeping current tests will require significant amount of work) and it doesn't make sense to have same tests in both cases.
  • removed unused unsignedVKs
  • remove default user
  • remove unused hardhat task

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link

coderabbitai bot commented Nov 13, 2023

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@zkokelj zkokelj force-pushed the ziga/remove_wallet_extension_endpoints branch 2 times, most recently from 25e346d to 4ae4bb9 Compare December 5, 2023 13:14
@tudor-malene
Copy link
Collaborator

@zkokelj , what is the status of this pr?

@zkokelj zkokelj force-pushed the ziga/remove_wallet_extension_endpoints branch from 96c267b to 6ba6509 Compare December 27, 2023 13:16
@zkokelj zkokelj force-pushed the ziga/remove_wallet_extension_endpoints branch 2 times, most recently from 360c98c to 6adc465 Compare January 4, 2024 13:52
@zkokelj zkokelj force-pushed the ziga/remove_wallet_extension_endpoints branch from 3f2be34 to b4567a7 Compare March 21, 2024 11:51
@zkokelj zkokelj force-pushed the ziga/remove_wallet_extension_endpoints branch from 70a9f04 to 27e08ea Compare March 21, 2024 12:27
@zkokelj zkokelj force-pushed the ziga/remove_wallet_extension_endpoints branch from e68882d to 4bbdf7d Compare March 22, 2024 13:38
@zkokelj zkokelj marked this pull request as ready for review March 22, 2024 16:04
Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zkokelj zkokelj merged commit 2288c3e into main Mar 25, 2024
3 checks passed
@zkokelj zkokelj deleted the ziga/remove_wallet_extension_endpoints branch March 25, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants