Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObscuroScan: small UI tweaks #1630

Merged
merged 1 commit into from
Oct 31, 2023
Merged

ObscuroScan: small UI tweaks #1630

merged 1 commit into from
Oct 31, 2023

Conversation

BedrockSquirrel
Copy link
Collaborator

What changes were made as part of this PR

  • Add title to transaction list for clarity
  • Show height, not batch seq number in batches table
  • Put placeholder for node count to get rid of spinner

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@coderabbitai
Copy link

coderabbitai bot commented Oct 31, 2023

Walkthrough

The recent changes primarily focus on enhancing the user interface of the ObscuroScan v2 tool. The modifications include updates to the display properties of data grids, addition of a new header for recent transactions, and a change in the loading message for the Nodes section.

Changes

File Path Summary
.../BatchDataGrid.vue The prop attribute of an el-table-column component has been updated from "sequencerOrderNo" to "number", affecting the label and width of the column. The ShortenedHash component is now used to display a shortened version of the hash value.
.../PublicTxDataGrid.vue An <el-header> element with the text "Recent transactions" has been added to the template.
.../SummaryItem.vue The loading message in the Nodes section has been replaced with a "Coming soon" message.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f6ac73a and dea66fe.
Files selected for processing (3)
  • tools/obscuroscan_v2/frontend/src/components/BatchDataGrid.vue (1 hunks)
  • tools/obscuroscan_v2/frontend/src/components/PublicTxDataGrid.vue (1 hunks)
  • tools/obscuroscan_v2/frontend/src/components/SummaryItem.vue (1 hunks)
Files skipped from review due to trivial changes (3)
  • tools/obscuroscan_v2/frontend/src/components/BatchDataGrid.vue
  • tools/obscuroscan_v2/frontend/src/components/PublicTxDataGrid.vue
  • tools/obscuroscan_v2/frontend/src/components/SummaryItem.vue

Copy link
Contributor

@zkokelj zkokelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BedrockSquirrel BedrockSquirrel merged commit 97ed3c3 into main Oct 31, 2023
2 checks passed
@BedrockSquirrel BedrockSquirrel deleted the matt/scan-batches branch October 31, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants