Add Obscuro network icon to add chain method #1535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkokelj
requested changes
Sep 20, 2023
| @@ -39,6 +39,7 @@ async function addNetworkToMetaMask(ethereum, userID, chainIDDecimal) { | |||
| { | |||
| chainId: chainIdHex, | |||
| chainName: 'Obscuro Testnet', | |||
| iconUrls: [https://raw.githubusercontent.com/obscuronet/go-obscuro/main/tools/walletextension/api/staticOG/Metamask%20Network%20Icon.png], | |||
There was a problem hiding this comment.
"" required when passing URL string
| @@ -39,6 +39,7 @@ async function addNetworkToMetaMask(ethereum, userID, chainIDDecimal) { | |||
| { | |||
| chainId: chainIdHex, | |||
| chainName: 'Obscuro Testnet', | |||
| iconUrls: [https://raw.githubusercontent.com/obscuronet/go-obscuro/main/tools/walletextension/api/staticOG/Metamask%20Network%20Icon.png], | |||
There was a problem hiding this comment.
This approach does not work.
See the official Metamask documentation: https://docs.metamask.io/wallet/reference/rpc-api/#wallet_addethereumchain
(parameter is currently ignored)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
The current Add Chain method was missing the Icons parameter & hence the network listed on Metamask didn't show the Obscuro icon.
What changes were made as part of this PR
Uploaded the Obscuro icon, as well as the parameter for the same in the Add Chain method.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks