Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add l1 block time config for host #1523

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

BedrockSquirrel
Copy link
Collaborator

Why this change is needed

Timings around retries and timeouts on the host depend on the host block size.

These times are very different between testnets and sims.

The hardcoded times we got by with are causing problems for the sepolia readiness work.

What changes were made as part of this PR

  • Add L1 block time field to host config
  • Default to 15s
  • Overridden by sims and tests

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BedrockSquirrel BedrockSquirrel merged commit 8768381 into main Sep 14, 2023
2 checks passed
@BedrockSquirrel BedrockSquirrel deleted the matt/add-l1-blocktime-conf branch September 14, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants