Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor storage to allow for different dbs + tests #1517

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

otherview
Copy link
Contributor

Why this change is needed

https://github.com/obscuronet/obscuro-internal/issues/2157

  • Storage was a passthrough
  • Tests need to work against sqllite and mariadb (in the future)
  • Small PR to make the upcoming remote database change easier.

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@otherview otherview requested a review from zkokelj September 13, 2023 16:01
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, optional nitpicks

tools/walletextension/wallet_extension.go Show resolved Hide resolved
tools/walletextension/storage/storage_test.go Outdated Show resolved Hide resolved
@otherview otherview force-pushed the pedro/og_tweak_storage branch from 53be3bd to 0148f61 Compare September 13, 2023 16:13
@otherview otherview merged commit 43e99a9 into main Sep 13, 2023
@otherview otherview deleted the pedro/og_tweak_storage branch September 13, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants