hardhat: ensure token script doesn't spin when waiting #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherview
reviewed
Sep 11, 2023
| @@ -95,8 +95,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) { | |||
| setTimeout(fail, 30_000) | |||
| const messageBusContract = (await hre.ethers.getContractAt('MessageBus', '0x526c84529b2b8c11f57d93d3f5537aca3aecef9b')); | |||
| while (await messageBusContract.callStatic.verifyMessageFinalized(messages[1]) != true) { | |||
| console.log(`Messages not stored on L2 yet, retrying...`); | |||
There was a problem hiding this comment.
Perhaps it's better to leave the log to see what's happening no ?
If we're tweaking this - we shouldn't do forever loops. What if this had an exit/fail condition ?
otherview
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Small bug in the sleep in this TS script means that we spin and create lots of promises instead of waiting 1sec between each one.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks