Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

micro-pr: skip files that are already mapped for enhanced stack traces #574

Merged
merged 1 commit into from
Jul 9, 2024
Merged

micro-pr: skip files that are already mapped for enhanced stack traces #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions temporalio/worker/_workflow_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1870,28 +1870,36 @@ def _enhanced_stack_trace(self) -> temporalio.api.sdk.v1.EnhancedStackTrace:

# this is to use `open`
with temporalio.workflow.unsafe.sandbox_unrestricted():
sources = dict()
stacks = []
sources: Dict[str, temporalio.api.sdk.v1.StackTraceFileSlice] = dict()
stacks: List[temporalio.api.sdk.v1.StackTrace] = []

# future TODO
# site package filter list -- we want to filter out traces from Python's internals and our sdk's internals. This is what `internal_code` is for, but right now it's just set to false.

for task in list(self._tasks):
locations = []
locations: List[temporalio.api.sdk.v1.StackTraceFileLocation] = []

for frame in task.get_stack():
filename = frame.f_code.co_filename
line_number = frame.f_lineno
func_name = frame.f_code.co_name

try:
with open(filename, "r") as f:
code = f.read()
except OSError as ose:
code = f"Cannot access code.\n---\n{ose.strerror}"
# TODO possibly include sentinel/property for success of src scrape? work out with ui
except Exception:
code = f"Generic Error.\n\n{traceback.format_exc()}"

file_slice = temporalio.api.sdk.v1.StackTraceFileSlice(
line_offset=0, content=code
)
if filename not in sources.keys():
try:
with open(filename, "r") as f:
code = f.read()
except OSError as ose:
code = f"Cannot access code.\n---\n{ose.strerror}"
# TODO possibly include sentinel/property for success of src scrape? work out with ui
except Exception:
code = f"Generic Error.\n\n{traceback.format_exc()}"

file_slice = temporalio.api.sdk.v1.StackTraceFileSlice(
line_offset=0, content=code
)

sources[filename] = file_slice

file_location = temporalio.api.sdk.v1.StackTraceFileLocation(
file_path=filename,
line=line_number,
Expand All @@ -1900,7 +1908,6 @@ def _enhanced_stack_trace(self) -> temporalio.api.sdk.v1.EnhancedStackTrace:
internal_code=False,
)

sources[filename] = file_slice
locations.append(file_location)

stacks.append(temporalio.api.sdk.v1.StackTrace(locations=locations))
Expand Down
Loading