Use ruff to auto-format code and sort imports. #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
ruff
branch
2 times, most recently
from
e6ec82e
to
82f6897
Compare
dandavison
force-pushed
the
ruff
branch
3 times, most recently
from
877de8f
to
d54b585
Compare
|
Ready for review, except for the failing 3.8 |
|
In addition to the comment about formatting generated protos, I also wonder if ruff can help us detect unused imports (haven't researched). I know imports have side-effects but surely there's some comment we can put around the false positives. |
cretz
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ruffto auto-format code and sort imports. This PR does not switch to using ruff as a general Python linter.After merge, we could add the commit to https://git-scm.com/docs/git-blame#Documentation/git-blame.txt-blameignoreRevsFile