Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging of error on activation failure #389

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

osobo
Copy link
Contributor

@osobo osobo commented Sep 26, 2023

What was changed

Explicitly include the error object in the logger.warning call after failure to activate on a workflow.

Why?

If the log call happens outside any except block and exc_info is just set to True no error information is included in the log (making it difficult to understand what caused the error).

@osobo osobo requested a review from a team as a code owner September 26, 2023 17:26
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I misread how exc_info works.

@cretz cretz merged commit d5edb71 into temporalio:main Sep 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants