Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose history size and continue-as-new-suggested #361

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Expose history size and continue-as-new-suggested #361

merged 1 commit into from
Aug 2, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Aug 2, 2023

What was changed

  • Added get_history_size() and is_continue_as_new_suggested() to workflow.info()
  • Added test to confirm behavior

@cretz cretz requested a review from a team as a code owner August 2, 2023 21:07
@cretz cretz mentioned this pull request Aug 2, 2023
Open
Sushisource
Sushisource approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names work for me

@cretz cretz merged commit 24fea4c into temporalio:main Aug 2, 2023
11 checks passed
@cretz cretz deleted the workflow-history-info branch August 2, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cretz @Sushisource @Quinn-With-Two-Ns