PR-suggested fixes

temporalio · Sep 28, 2023 · dd301cd · dd301cd
1 parent 9f9b811
commit dd301cd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/temporalio/bridge/src/metric.rs b/temporalio/bridge/src/metric.rs
@@ -257,7 +257,7 @@ fn convert_metric_event<'p>(
                         },
                     },
                 )
-                .unwrap(),
+                .expect("Unable to create buffered metric"),
             );
             populate_into.set(Arc::new(buffered_ref)).unwrap();
             None
@@ -275,11 +275,11 @@ fn convert_metric_event<'p>(
                     .clone()
                     .as_any()
                     .downcast::<BufferedMetricAttributes>()
-                    .unwrap()
+                    .expect("Unable to downcast to expected buffered metric attributes")
                     .0
                     .as_ref(py)
                     .copy()
-                    .unwrap()
+                    .expect("Failed to copy metric attribute dictionary")
                     .into(),
                 None => PyDict::new(py).into(),
             };
@@ -292,12 +292,12 @@ fn convert_metric_event<'p>(
                     metrics::MetricValue::Float(v) => new_attrs.set_item(kv.key, v),
                     metrics::MetricValue::Bool(v) => new_attrs.set_item(kv.key, v),
                 }
-                .unwrap();
+                .expect("Unable to set metric key/value on dictionary");
             }
             // Put on lazy ref
             populate_into
                 .set(Arc::new(BufferedMetricAttributes(new_attrs_ref)))
-                .unwrap();
+                .expect("Unable to set buffered metric attributes on reference");
             None
         }
         // Convert to Python metric event
@@ -316,7 +316,7 @@ fn convert_metric_event<'p>(
                 .clone()
                 .as_any()
                 .downcast::<BufferedMetricAttributes>()
-                .unwrap()
+                .expect("Unable to downcast to expected buffered metric attributes")
                 .0
                 .clone(),
         }),

diff --git a/temporalio/bridge/src/runtime.rs b/temporalio/bridge/src/runtime.rs
@@ -134,7 +134,7 @@ impl RuntimeRef {
             self.runtime
                 .metrics_call_buffer
                 .as_ref()
-                .unwrap()
+                .expect("Attempting to retrieve buffered metrics without buffer")
                 .retrieve(),
         )
     }

diff --git a/temporalio/runtime.py b/temporalio/runtime.py
@@ -197,7 +197,8 @@ def __init__(self, buffer_size: int) -> None:
             and is drained regularly. See :py:class:`MetricBuffer` warning.
 
         Args:
-            buffer_size: Size of the buffer. Set this to a large value.
+            buffer_size: Size of the buffer. Set this to a large value. A value
+                in the tens of thousands or higher is plenty reasonable.
         """
         self._buffer_size = buffer_size
         self._runtime: Optional[Runtime] = None