doc: Clarify UnableToAcquireLockException (#2359)
#2360
Conversation
GitHub Issue #2359
GSmithApps
force-pushed
the
2359-exception-doc-enhancement
branch
from
a71d0c8 to
06855df
Compare
| "Workflow lock for the run id hasn't been released by one of previous execution attempts, " | ||
| + "consider increasing workflow task timeout."); | ||
| "Workflow lock for the run id hasn't been released by one of previous execution attempts. " | ||
| + "This likely means the workflow task timed out, and the Service attempted to " |
There was a problem hiding this comment.
This exception can be thrown any time the workflow lock cannot be acquire because another task is holding the lock. It can happen because of workflow task timeout, but that is misleading to suggest it is likely or to recommend investigating Workflow Task timed out without doing some triage. This error can have multiple causes including something happening on the Temporal Server side
| + "This likely means the workflow task timed out, and the Service attempted to " | |
| "Workflow lock for the run id hasn't been released by one of previous execution attempts. This means another workflow task is holding the lock. If seen repeatedly users should investigate the failing workflow executions for more details." |
|
Hi Quinn, thanks so much for looking at this PR! I'm not sure if you saw the Slack thread in the comment from me above, but I was trying to get ahead of a question similar to that in the future, because judging by Tiho's comment, Kapa went down the wrong path. I figured if we gave it a little more direction in the exception description, we might be able to avoid that. Do you think there's any clarifying or expanding to do, or should we leave it as it was before this PR? Also, if this warrants more discussion or anything, I'm happy to chat over Slack 🙂 |
Closes #2359 (which is to help clarify this Slack thread)