Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDKTestWorkflowRule wasn't calling shutdown #2243

Merged
merged 2 commits into from
Oct 1, 2024
Merged

SDKTestWorkflowRule wasn't calling shutdown #2243

merged 2 commits into from
Oct 1, 2024

Conversation

mfateev
Copy link
Member

@mfateev mfateev commented Sep 28, 2024

What was changed

Fixed SDKTestWorkflowRule to call shutdown. After the fix, multiple unit tests broke as expectations were out of date. Fixed them as well.

@mfateev mfateev requested a review from a team as a code owner September 28, 2024 04:39
@alexshtin alexshtin changed the title SDKTestWorkflowRule wasn't calling shutdown. SDKTestWorkflowRule wasn't calling shutdown Oct 1, 2024
@mfateev mfateev merged commit 156f4f1 into temporalio:master Oct 1, 2024
8 checks passed
@mfateev mfateev deleted the unit-test-fix branch October 1, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfateev @Quinn-With-Two-Ns