Skip to content

Commit

Permalink
mark the nexus sdk as an api dep. (#2269)
Browse files Browse the repository at this point in the history
  • Loading branch information
Quinn-With-Two-Ns authored Oct 15, 2024
1 parent 0aa31f0 commit a622800
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 6 deletions.
1 change: 0 additions & 1 deletion temporal-kotlin/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ dependencies {

// this module shouldn't carry temporal-sdk with it, especially for situations when users may be using a shaded artifact
compileOnly project(':temporal-sdk')
implementation "io.nexusrpc:nexus-sdk:$nexusVersion"

implementation "org.jetbrains.kotlin:kotlin-reflect"

Expand Down
2 changes: 1 addition & 1 deletion temporal-sdk/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dependencies {
api project(':temporal-serviceclient')
api "com.google.code.gson:gson:$gsonVersion"
api "io.micrometer:micrometer-core"
implementation "io.nexusrpc:nexus-sdk:$nexusVersion"
api "io.nexusrpc:nexus-sdk:$nexusVersion"

implementation "com.google.guava:guava:$guavaVersion"
api "com.fasterxml.jackson.core:jackson-databind"
Expand Down
3 changes: 3 additions & 0 deletions temporal-shaded/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ dependencies {
shadow "com.google.guava:failureaccess:1.0.1"
shadow "com.google.guava:guava:$guavaVersion"

// nexus
shadow "io.nexusrpc:nexus-sdk:$nexusVersion"

// grpc
shadow "io.grpc:grpc-protobuf-lite:$grpcVersion"
shadow "io.grpc:grpc-protobuf:$grpcVersion"
Expand Down
1 change: 0 additions & 1 deletion temporal-spring-boot-autoconfigure/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ ext {
dependencies {
api(platform("org.springframework.boot:spring-boot-dependencies:$springBootVersion"))
api(platform("io.opentelemetry:opentelemetry-bom:$otelVersion"))
implementation "io.nexusrpc:nexus-sdk:$nexusVersion"

compileOnly project(':temporal-sdk')
compileOnly project(':temporal-testing')
Expand Down
1 change: 0 additions & 1 deletion temporal-test-server/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ dependencies {
//needed for the generated grpc stubs and is not a part of JDK since java 9
compileOnly "javax.annotation:javax.annotation-api:$annotationApiVersion"
}
implementation "io.nexusrpc:nexus-sdk:$nexusVersion"

implementation "com.google.guava:guava:$guavaVersion"
implementation("com.cronutils:cron-utils:${cronUtilsVersion}") {
Expand Down
2 changes: 0 additions & 2 deletions temporal-testing/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ dependencies {
implementation("com.jayway.jsonpath:json-path:$jsonPathVersion"){
exclude group: 'org.slf4j', module: 'slf4j-api'
}
implementation "io.nexusrpc:nexus-sdk:$nexusVersion"


junit4Api 'junit:junit:4.13.2'

Expand Down

0 comments on commit a622800

Please sign in to comment.