Support mocking Nexus operation with operation reference #1683
Conversation
|
It would be nice to have some tests using this new approach so we can see how it would be used. |
rodrigozhou
force-pushed
the
rodrigozhou/nexus-test-op-ref
branch
from
be8eb9e
to
d3f9212
Compare
|
@Quinn-With-Two-Ns Added a test using it. |
rodrigozhou
force-pushed
the
rodrigozhou/nexus-test-mocks
branch
from
f6df7a0
to
3bb0bb9
Compare
rodrigozhou
force-pushed
the
rodrigozhou/nexus-test-op-ref
branch
from
d3f9212
to
a8478ba
Compare
rodrigozhou
force-pushed
the
rodrigozhou/nexus-test-op-ref
branch
from
a8478ba
to
7ffdf3b
Compare
| } | ||
| case testNexusOperationReference: | ||
| // This case covers both nexus.RegisterableOperation and nexus.OperationReference. | ||
| // All nexus.RegisterableOperation embeds nexus.UnimplementedOperation which |
There was a problem hiding this comment.
nit: may want to setup a check to enforce this in the Go SDK since the Nexus SDK is not stable , but I guess your unit test would fail so maybe redundant.
There was a problem hiding this comment.
Very minor comments left. I'll leave it up to @Quinn-With-Two-Ns to approve.
| mockErr, | ||
| )) | ||
| } | ||
|
|
||
| mockResult := mockRet[0] | ||
| ret, ok := mockResult.(nexus.HandlerStartOperationResult[any]) | ||
| result, ok := mockResult.(nexus.HandlerStartOperationResult[any]) |
There was a problem hiding this comment.
I'm surprised this works in Go as nexus.HandlerStartOperationResult[T] isn't assignable to nexus.HandlerStartOperationResult[any]. But looks like your test below is passing.
rodrigozhou
force-pushed
the
rodrigozhou/nexus-test-op-ref
branch
from
4f6ada0
to
4540ab3
Compare
There was a problem hiding this comment.
Approved with comments. Nothing too major. Still want @Quinn-With-Two-Ns to do the last pass.
rodrigozhou
force-pushed
the
rodrigozhou/nexus-test-op-ref
branch
from
b0d19d6
to
33bb799
Compare
* Support mocking Nexus operation with operation reference * address comments * address comments
* Support for mocking nexus operations * address comments * add tests * add nexus events listeners * add test for nexus listeners * address comments * add assert nexus calls methods * address static checks * Support mocking Nexus operation with operation reference (#1683) * Support mocking Nexus operation with operation reference * address comments * address comments
What was changed
Support mocking Nexus operation using
nexus.OperationReference.Why?
The user won't need to create a dummy implementation of Nexus operation to mock it.
Checklist
Closes
How was this tested: