Add Nexus failure_reason metric tag
#1671
Conversation
| // NexusTaskFailureTags returns a set of tags for Nexus Operation failures. | ||
| func NexusTaskFailureTags(reason string) map[string]string { | ||
| return map[string]string{ | ||
| FailureReasonTagName: reason, |
There was a problem hiding this comment.
Is it possible to, somewhere, clarify all possible enumerate values here? Some spec or something for SDKs to follow. I want to make sure it's a fixed enumerate, that all SDKs share them, and we are ok with the casing of the values.
There was a problem hiding this comment.
My plan was to put this in our docs in /sdk-metrics. Does that work for you?
There was a problem hiding this comment.
Sure! I would like to confirm the values before merging this (can add them in here if easiest).
There was a problem hiding this comment.
There was a problem hiding this comment.
So to confirm, it's handler_error_NOT_IMPLEMENTED not all consistent cased, correct? I don't mind, just checking.
There was a problem hiding this comment.
Yes, that's correct. Do you think it's worth doing a lower case conversion here?
I updated the docs PR to use upper case letters.
There was a problem hiding this comment.
For gRPC errors the status_code tag is all caps
There was a problem hiding this comment.
Let's move on. I think we agree it's fine as long as it's consistent and documented.
|
On the test failure |
A follow up for #1664 where we decided to add more information on Nexus task failures.