Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in documentation #1288

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix typo in documentation #1288

merged 2 commits into from
Nov 8, 2023

Conversation

theleeeo
Copy link
Contributor

@theleeeo theleeeo commented Nov 7, 2023

Fix some typos in the example for handling errors

What was changed

Fix some typos on the documentation about error handling

Why?

This change was done for two reasons:

  1. It was unsatisfying to see
  2. If someone copies the example and uses it as a base for their own error handling the example should be working.

Checklist

  1. How was this tested:
    This only includes some changes to comments so no executable code is affected. Therefor it is untested

@theleeeo theleeeo requested a review from a team as a code owner November 7, 2023 15:08
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Quinn-With-Two-Ns
Copy link
Contributor

Thanks for the contribution, this whole error switch should be its own sample

theleeeo and others added 2 commits November 8, 2023 11:47
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 4663bab into temporalio:master Nov 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theleeeo @CLAassistant @Quinn-With-Two-Ns