-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gogo protobuf #1256
Merged
tdeebswihart
merged 46 commits into
temporalio:master
from
tdeebswihart:replace-gogo-protobuf
Nov 21, 2023
Merged
Replace gogo protobuf #1256
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
d507797
Begin converting the SDK off of gogo/protobuf
tdeebswihart becd938
Convert more over to google's protobuf
tdeebswihart 789c142
Repoint all other modules at my forks
tdeebswihart 94c5bff
Fix copying of retry policies
tdeebswihart 4e3f025
Update converter tests and explicitly test gogo
tdeebswihart 39c3a58
Move history loading to api-go repo and update tests
tdeebswihart 19d9a24
Fix more tests that relied on old enum naming
tdeebswihart f0508cf
Use common duration and timestamp conversion helpers
tdeebswihart d26360f
Replace a new reference to gogo's any type
tdeebswihart 720b77e
Use useful replace directives and tidy all modules
tdeebswihart 213fd0d
Address review comments
tdeebswihart 66817b8
Fix fmt call I made unnecessarily complex
tdeebswihart 5e9c4c6
Remove unused helper function
tdeebswihart a626c00
Use the new api-go jsonpb code
tdeebswihart 59e8215
Use the newly renamed temporalproto code
tdeebswihart b642ecd
Bump api-go and fix test metrics
tdeebswihart 8d4cfc0
Update go-api dep
tdeebswihart e0317be
Use my fork of our features repo
tdeebswihart f407630
Don't use my fork of the features repo
tdeebswihart 1309c0b
Bump dependencies
tdeebswihart fc3a5c7
Missed a go.mod, whoops.
tdeebswihart d26cde7
Fix how we check if times are specified
tdeebswihart 3717ab9
I can't replicate this locally so need to do so in CI...
tdeebswihart f3b6f59
See previous commit...
tdeebswihart 191aee1
This will be a long project
tdeebswihart b48ff6d
Use my features repo once more
tdeebswihart 40c1f96
Let's see if this is enough
tdeebswihart bc3a74f
Fix time bugs
tdeebswihart 7ca2c2a
Those aren't times but durations
tdeebswihart 60326cd
Don't print private fields in proto objects
tdeebswihart 2c2c5d2
I flipped the logic without flipping the regexp...
tdeebswihart 73c3aaa
Add some debugging
tdeebswihart 0d40b87
Try a new format
tdeebswihart c1bfc6b
Update how we print
tdeebswihart f42a9db
Bump api-go dependency
tdeebswihart c47df1f
Specify DiscardUnknown on our history json decoders
tdeebswihart d083a5f
Address review comments
tdeebswihart 99988e4
Fix replay workflow error message
tdeebswihart 49eced6
Bump go-api version
tdeebswihart 9e29e05
Bump api-go dependency
tdeebswihart 31d0607
I forgot the test directory
tdeebswihart edc4bbe
Bump all go versions to 1.20 and tidy
tdeebswihart e73f11e
math/rand has been deprecated and errcheck fails on it
tdeebswihart d440028
Handle the error from rand.Read
tdeebswihart 07a2c7e
Bump version of api-go
tdeebswihart a11ee59
Remove references to my fork of api-go
tdeebswihart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,53 @@ | ||
module go.temporal.io/sdk/contrib/datadog | ||
|
||
go 1.16 | ||
go 1.20 | ||
|
||
require ( | ||
github.com/stretchr/testify v1.8.4 | ||
go.temporal.io/sdk v1.12.0 | ||
gopkg.in/DataDog/dd-trace-go.v1 v1.42.0 | ||
) | ||
|
||
require ( | ||
github.com/DataDog/datadog-agent/pkg/obfuscate v0.0.0-20211129110424-6491aa3bf583 // indirect | ||
github.com/DataDog/datadog-go v4.8.2+incompatible // indirect | ||
github.com/DataDog/datadog-go/v5 v5.0.2 // indirect | ||
github.com/DataDog/sketches-go v1.2.1 // indirect | ||
github.com/Microsoft/go-winio v0.5.1 // indirect | ||
github.com/cespare/xxhash/v2 v2.2.0 // indirect | ||
github.com/davecgh/go-spew v1.1.1 // indirect | ||
github.com/dgraph-io/ristretto v0.1.0 // indirect | ||
github.com/dustin/go-humanize v1.0.0 // indirect | ||
github.com/facebookgo/clock v0.0.0-20150410010913-600d898af40a // indirect | ||
github.com/gogo/protobuf v1.3.2 // indirect | ||
github.com/golang/glog v1.1.2 // indirect | ||
github.com/golang/mock v1.6.0 // indirect | ||
github.com/golang/protobuf v1.5.3 // indirect | ||
github.com/google/uuid v1.3.1 // indirect | ||
github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 // indirect | ||
github.com/grpc-ecosystem/grpc-gateway/v2 v2.18.1 // indirect | ||
github.com/josharian/intern v1.0.0 // indirect | ||
github.com/mailru/easyjson v0.7.7 // indirect | ||
github.com/pborman/uuid v1.2.1 // indirect | ||
github.com/philhofer/fwd v1.1.1 // indirect | ||
github.com/pkg/errors v0.9.1 // indirect | ||
github.com/pmezard/go-difflib v1.0.0 // indirect | ||
github.com/robfig/cron v1.2.0 // indirect | ||
github.com/stretchr/objx v0.5.0 // indirect | ||
github.com/tinylib/msgp v1.1.2 // indirect | ||
go.temporal.io/api v1.26.1-0.20231121220434-5a4d95cc60c0 // indirect | ||
go.uber.org/atomic v1.9.0 // indirect | ||
golang.org/x/net v0.18.0 // indirect | ||
golang.org/x/sys v0.14.0 // indirect | ||
golang.org/x/text v0.14.0 // indirect | ||
golang.org/x/time v0.3.0 // indirect | ||
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect | ||
google.golang.org/genproto v0.0.0-20231120223509-83a465c0220f // indirect | ||
google.golang.org/genproto/googleapis/api v0.0.0-20231120223509-83a465c0220f // indirect | ||
google.golang.org/genproto/googleapis/rpc v0.0.0-20231120223509-83a465c0220f // indirect | ||
google.golang.org/grpc v1.59.0 // indirect | ||
google.golang.org/protobuf v1.31.0 // indirect | ||
gopkg.in/yaml.v3 v3.0.1 // indirect | ||
) | ||
|
||
replace go.temporal.io/sdk => ../../ |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goes without saying, just making reminder to update this and similar places when temporalio/api-go#119 is merged