[WIP] Clear workflowExecutionIsCancelling on new WFT #1175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
clear-execution-is-cancelling
branch
from
64846ba
to
ff58401
Compare
|
Closing in favor of #1181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear
workflowExecutionIsCancellingon new WFT.As far as I can tell
workflowExecutionIsCancellingis only needed because on workflow cancelation we generate the cancel commands eagerly before the WFT started and when we process the WFT started event we reset the eventID the Go SDK uses for counting so this throws off everything in the SDK. The problem with the current implementation is it assumes all cancels after a workflow cancel request are a result of the cancel request and that is not true.I believe after the cancel request callback is processed this whole
workflowExecutionIsCancellinglogic should not be needed since all the out of workflow execution callbacks should be done, but I could be wrong on this point.I think the best solution would be to remove this
workflowExecutionIsCancellingand generate the cancel commands after setting the eventID on WFT started, but there is a 2+ year history of cancellation issues around this so It is very possible I am missing something.Summary of the history of this flag:
#726
Fix for #1176