Unlock before panicking #1168
Merged
Unlock before panicking #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move commit info to env var to mitigate run injection vulnerability.
The logic of the function seems like a defer wouldn't unlock in order for that deferred function to handle updating the d.executing state.
|
What is the goal of this change? what bug/issue does this resolve? |
|
This is responding to a finding in Semgrep. If we try to recover from this panic, we presumably will still have left that dispatcher locked and wouldn't expect that, so we couldn't properly recover. |
cretz
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
While I think we sometimes lock mutexes we intentionally do not unlock locally, I don't think this is one of those cases. It's just really-old pre-Temporal missed code I think (and highly unlikely these conditions are ever satisfied at runtime).
Will let @Quinn-With-Two-Ns review/merge.
Quinn-With-Two-Ns
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Unlock a locked dispatcher mutex before panicking.
Why?
Since it needs to be unlocked to finish running coroutines, and then relocked long enough to have the status changed to not executing, defer didn't fit.
Checklist
How was this tested:
make test is currently failing integration tests