Skip to content

Commit

Permalink
Fix Version test failure due to 1.25.0 server release (#1629)
Browse files Browse the repository at this point in the history
* temporary test fix

* change assert to match server behavior change
  • Loading branch information
yuandrew authored Sep 10, 2024
1 parent c8cb430 commit fa54195
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/worker_versioning_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,8 @@ func (ts *WorkerVersioningTestSuite) TestCommitRules() {
// replace all rules by unconditional "2.0"
ts.Equal(1, len(res.AssignmentRules))
ts.Equal("2.0", res.AssignmentRules[0].Rule.TargetBuildID)
_, ok := res.AssignmentRules[0].Rule.Ramp.(*client.VersioningRampByPercentage)
ts.Falsef(ok, "Still has a percentage ramp")
ramp, ok := res.AssignmentRules[0].Rule.Ramp.(*client.VersioningRampByPercentage)
ts.Truef(!ok || ramp.Percentage == 100, "There should either be no ramp or ramp should be 100%")
}

func (ts *WorkerVersioningTestSuite) TestConflictTokens() {
Expand Down

0 comments on commit fa54195

Please sign in to comment.