d.mutex.Unlock()

The logic of the function seems like a defer wouldn't unlock in order for that deferred function to handle updating the d.executing state.
temporalio · Jul 21, 2023 · f8ab872 · f8ab872
1 parent 8f13360
commit f8ab872
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/internal/internal_workflow.go b/internal/internal_workflow.go
@@ -1056,9 +1056,11 @@ func (d *dispatcherImpl) newState(name string) *coroutineState {
 func (d *dispatcherImpl) ExecuteUntilAllBlocked(deadlockDetectionTimeout time.Duration) (err error) {
 	d.mutex.Lock()
 	if d.closed {
+		d.mutex.Unlock()
 		panic("dispatcher is closed")
 	}
 	if d.executing {
+		d.mutex.Unlock()
 		panic("call to ExecuteUntilAllBlocked (possibly from a coroutine) while it is already running")
 	}
 	d.executing = true