Add GHA for building promql-to-scrape #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taonic
force-pushed
the
taonic/add-GHA-to-build-promql-to-scrape
branch
6 times, most recently
from
ec60964
to
83ff47c
Compare
|
Build was fine but failed when pushing to ghcr since It shouldn't be the case once it's on |
TimSimmons
approved these changes
May 7, 2024
| @@ -1,11 +1,24 @@ | |||
| FROM golang:1.21-alpine | |||
| FROM --platform=${BUILDPLATFORM:-linux/amd64} golang:1.20 as builder | |||
There was a problem hiding this comment.
1.21? probably doesn't matter but just to stay consistent
taonic
force-pushed
the
taonic/add-GHA-to-build-promql-to-scrape
branch
from
83ff47c
to
22b5bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adding GHA workflow to build https://github.com/temporalio/samples-server/tree/main/cloud/observability/promql-to-scrape and publish to https://github.com/orgs/temporalio/packages
Why?
Checklist
Closes
How was this tested: